Keep targets like "@foo//:foo" formatted as-is. #1355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update golden file.
Member
|
please revert this. this is a long-standing label syntax (and documented) that the community has come to rely on. |
vladmos
pushed a commit
that referenced
this pull request
Apr 25, 2025
This was referenced Apr 30, 2025
oreflow
pushed a commit
that referenced
this pull request
May 5, 2025
* Keep targets like "@foo//:foo" formatted as-is. See #1354 * Update 019.build.golden Update golden file.
oreflow
pushed a commit
that referenced
this pull request
May 5, 2025
oreflow
pushed a commit
that referenced
this pull request
May 5, 2025
* Keep targets like "@foo//:foo" formatted as-is. See #1354 * Update 019.build.golden Update golden file.
oreflow
pushed a commit
that referenced
this pull request
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix incorrect rewrites of
@foo//:foo. Encountered when renaming@com_google_re2//:re2to@re2//:re2.buildifier should leave these as-is since in
@re2//:re2, the repository isre2, the package is the empty string, and the target isre2, and it is not correct to assume that repositories have stable names.#1354