Skip to content

Conversation

@fmeum
Copy link
Contributor

@fmeum fmeum commented Dec 13, 2023

No description provided.

@fmeum
Copy link
Contributor Author

fmeum commented Dec 13, 2023

@Wyverald Could you review this as well?

@fmeum fmeum force-pushed the fix-repo-boundary branch from 3b7a427 to cad8388 Compare December 17, 2023 11:35
@fmeum
Copy link
Contributor Author

fmeum commented Dec 17, 2023

@vladmos I fixed one test failure in the buildifier integration test, but I don't understand the test setup for the remaining another_test_dir failure to the extent required to fix the new failure caused by that fix.

Edit: I pushed a slightly hacky fix.

@fmeum fmeum force-pushed the fix-repo-boundary branch 2 times, most recently from 9fd2996 to 435c1b3 Compare December 18, 2023 09:31
@fmeum
Copy link
Contributor Author

fmeum commented Dec 18, 2023

The Windows failure seems unrelated.

@fmeum fmeum force-pushed the fix-repo-boundary branch from abd08fa to 2615c8b Compare April 18, 2024 09:36
@fmeum
Copy link
Contributor Author

fmeum commented Apr 18, 2024

I fixed the CI failures.

@Wyverald
Copy link
Member

i'll go ahead and merge this since it looks fairly straightforward.

@Wyverald Wyverald merged commit 82469e9 into bazelbuild:master Apr 18, 2024
@fmeum fmeum deleted the fix-repo-boundary branch April 18, 2024 10:39
apattidb pushed a commit to databricks/buildtools that referenced this pull request May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants