yosys@0.64#8862
Merged
Merged
Conversation
Adds yosys 0.64 to BCR. Overlay changes vs 0.62.bcr.2 needed for v0.64 source layout: - `VERSION = "0.64"` in `overlay/BUILD.bazel`. - `passes/opt/opt_clean.cc` split upstream into the directory `passes/opt/opt_clean/` — list `cells_all.cc`, `cells_temp.cc`, `inits.cc`, `opt_clean.cc`, `wires.cc` instead, and add `opt_clean.h` + `keep_cache.h` to `pass_opt` textual_hdrs. - Add `kernel/newcelltypes.h` to the kernel cc_library's hdrs. - Both inner and outer `MODULE.bazel` version bumped to 0.64. Patch changes: - `tcl9_mp_to_ubin.patch` — applies clean (verbatim from 0.62.bcr.2). - `use_cxxopt_module.patch` — context line refresh: v0.64 adds `#include <chrono>` immediately after `#include <iostream>`, so the hunk's bottom context needed to be updated (otherwise applies with `--fuzz 2`, which BCR validation rejects). source.json refreshed: v0.64 tarball integrity, new BUILD.bazel / MODULE.bazel / use_cxxopt patch sha256s. `tools/bcr_validation.py --check yosys@0.64` passes all checks. Upstream release notes: https://github.com/YosysHQ/yosys/releases/tag/v0.64 Signed-off-by: Øyvind Harboe <oyvind@ascenium.com>
Member
|
Hello @UebelAndre, modules you maintain (yosys) have been updated in this PR. |
Closed
Add threading_includes.patch to unconditionally include <mutex>,
<condition_variable>, and <thread> in kernel/threading.h. v0.64's
work-steal queue (ConcurrentWorkQueue::wait_for_work, line ~635)
uses std::unique_lock unconditionally, but the headers are gated
behind #ifdef YOSYS_ENABLE_THREADS. On non-threaded builds (BCR
overlay does not define YOSYS_ENABLE_THREADS), gcc 13+ rejects this
with:
'std::unique_lock' is not a member of 'std' [-Wtemplate-body]
Reproduced locally on bazel 8.x with system gcc; BCR presubmit on
ubuntu 22.04 / 24.04 / debian13 / arm64 confirmed the same.
ubuntu20.04 (gcc 9) was lenient enough to compile despite the
missing include, hence the partial CI pass.
Signed-off-by: Øyvind Harboe <oyvind@ascenium.com>
oharboe
added a commit
to oharboe/bazel-central-registry
that referenced
this pull request
May 13, 2026
v0.65 carries v0.64's work-steal queue with the same unconditional std::unique_lock use outside YOSYS_ENABLE_THREADS. Mirror PR bazelbuild#8862's threading_includes.patch fix here so non-threaded gcc 13+ builds compile. Signed-off-by: Øyvind Harboe <oyvind@ascenium.com>
This was referenced May 13, 2026
Merged
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Contributor
Author
|
@UebelAndre Do you need anything else from me? Thanks! |
3 tasks
Contributor
Author
|
@MrAMS Is this something you could review? |
Contributor
Unfortunately, I'm not a maintainer of this module. 😢 |
UebelAndre
approved these changes
May 26, 2026
UebelAndre
left a comment
Contributor
There was a problem hiding this comment.
Sorry for the delay, looks good!
Contributor
Author
😌 There are a couple more versions for abc and yosys, could you look at those too? |
oharboe
added a commit
to oharboe/bazel-central-registry
that referenced
this pull request
May 26, 2026
Adds yosys 0.65 to BCR. Overlay changes vs 0.64 for v0.65 source layout: - `VERSION = "0.65"` in `overlay/BUILD.bazel`. - New kernel header `kernel/wallace_tree.h` added to kernel `hdrs`. - New `passes/techmap/arith_tree.cc` added to `pass_techmap` srcs. - New `passes/techmap/liberty_cache.h` added to `pass_techmap` hdrs. - Inner and outer `MODULE.bazel` version bumped to 0.65. Patches: - `tcl9_mp_to_ubin.patch` — applies clean (verbatim from 0.64). - `use_cxxopt_module.patch` — applies clean (verbatim from 0.64). source.json refreshed: v0.65 tarball integrity + new sha256s for BUILD.bazel and overlay/MODULE.bazel. `tools/bcr_validation.py --check yosys@0.65` passes all checks. Stacks on top of bazelbuild#8862 (yosys@0.64) — metadata.json edit may need rebase once bazelbuild#8861/bazelbuild#8862 land. Upstream release notes: https://github.com/YosysHQ/yosys/releases/tag/v0.65 Signed-off-by: Øyvind Harboe <oyvind@ascenium.com>
oharboe
added a commit
to oharboe/bazel-central-registry
that referenced
this pull request
May 26, 2026
v0.65 carries v0.64's work-steal queue with the same unconditional std::unique_lock use outside YOSYS_ENABLE_THREADS. Mirror PR bazelbuild#8862's threading_includes.patch fix here so non-threaded gcc 13+ builds compile. Signed-off-by: Øyvind Harboe <oyvind@ascenium.com>
1 task
oharboe
added a commit
to The-OpenROAD-Project/bazel-orfs
that referenced
this pull request
May 26, 2026
yosys 0.64 (bazelbuild/bazel-central-registry#8862) has landed in official BCR. No fork-registry fallback is needed; Bazel's default registry (BCR) covers all module versions referenced here. Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds yosys 0.64 to BCR.
Overlay changes vs 0.62.bcr.2 required for v0.64 source layout:
VERSION = "0.64"inoverlay/BUILD.bazel.passes/opt/opt_clean.ccis split upstream into the directorypasses/opt/opt_clean/. Thepass_optcc_library now lists theper-file split (
cells_all.cc,cells_temp.cc,inits.cc,opt_clean.cc,wires.cc) and exposesopt_clean.h+keep_cache.hvia textual_hdrs.kernel/newcelltypes.hadded to kernel'shdrs.passes/equiv/equiv.h(introduced in v0.63) added topass_equivtextual_hdrs (carried forward from the yosys@0.63 PR).
MODULE.bazelversion bumped to 0.64.Patches:
tcl9_mp_to_ubin.patch— verbatim from 0.62.bcr.2, applies clean.use_cxxopt_module.patch— context line refresh. v0.64 adds#include <chrono>after#include <iostream>, so the trailingcontext of the existing hunk was updated (otherwise applies with
--fuzz 2, which BCR's--fuzz 0validation rejects).source.json refreshed: v0.64 tarball integrity + new sha256 for
BUILD.bazel, overlay/MODULE.bazel, and use_cxxopt_module.patch.
Local verification:
bazelisk run @yosys//:yosys -- -Vagainst thisfork branch as a custom registry prints
Yosys 0.64.tools/bcr_validation.py --check yosys@0.64passes all checks.Stacks on top of #8861 (yosys@0.63) — metadata.json edit may need
rebase once #8861 lands.
Upstream release notes:
https://github.com/YosysHQ/yosys/releases/tag/v0.64