Skip to content

rules_graalvm@0.9.2#869

Closed
publish-to-bcr-bot[bot] wants to merge 1 commit intobazelbuild:mainfrom
sgammon:sgammon/rules_graalvm@v0.9.2-640133bb
Closed

rules_graalvm@0.9.2#869
publish-to-bcr-bot[bot] wants to merge 1 commit intobazelbuild:mainfrom
sgammon:sgammon/rules_graalvm@v0.9.2-640133bb

Conversation

@publish-to-bcr-bot
Copy link
Copy Markdown
Contributor

Release author: @sgammon.

Automated by Publish to BCR.

{
"integrity": "sha256-QdNrBX1XYMqLPVyJSqMuKBB753rVYk6ukY6cujk8KZM=",
"strip_prefix": "rules_graalvm-0.9.2",
"url": "https://github.com/sgammon/rules_graalvm/archive/refs/tags/v0.9.2.tar.gz"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you control the repo, could you add and reference a release archive?

Comment on lines +1 to +5
{
"integrity": "sha256-QdNrBX1XYMqLPVyJSqMuKBB753rVYk6ukY6cujk8KZM=",
"strip_prefix": "rules_graalvm-0.9.2",
"url": "https://github.com/sgammon/rules_graalvm/archive/refs/tags/v0.9.2.tar.gz"
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{
"integrity": "sha256-QdNrBX1XYMqLPVyJSqMuKBB753rVYk6ukY6cujk8KZM=",
"strip_prefix": "rules_graalvm-0.9.2",
"url": "https://github.com/sgammon/rules_graalvm/archive/refs/tags/v0.9.2.tar.gz"
}
{
"integrity": "sha256-1CALzEPlrU5pScGx7cHln2MGbjoigNW9gtDJsdZ8Pyw=",
"strip_prefix": "rules_graalvm-0.9.2",
"url": "https://github.com/sgammon/rules_graalvm/releases/download/v0.9.2/rules_graalvm-0.9.2.tar.gz"
}

Just noticed that there is a release archive, will try with that one.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sgammon I don't have write access to your branch, could you apply the suggestion or insert your release archive yourself?

sgammon added a commit to sgammon/rules_graalvm that referenced this pull request Sep 1, 2023
- fix: set the BCR download endpoint for `rules_graalvm` to the
  release artifact, which is stable

Referenced in bazelbuild/bazel-central-registry#869

Signed-off-by: Sam Gammon <sam@elide.ventures>
sgammon added a commit to sgammon/rules_graalvm that referenced this pull request Sep 1, 2023
- fix: set the BCR download endpoint for `rules_graalvm` to the
  release artifact, which is stable

Referenced in bazelbuild/bazel-central-registry#869

Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon
Copy link
Copy Markdown
Contributor

sgammon commented Sep 8, 2023

these can be closed, superseded by #836

@fmeum fmeum closed this Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants