Skip to content

rules_python@0.25.0#863

Merged
Wyverald merged 1 commit intobazelbuild:mainfrom
f0rmiga:bazelbuild/rules_python@0.25.0-f71915b0
Aug 22, 2023
Merged

rules_python@0.25.0#863
Wyverald merged 1 commit intobazelbuild:mainfrom
f0rmiga:bazelbuild/rules_python@0.25.0-f71915b0

Conversation

@publish-to-bcr-bot
Copy link
Copy Markdown
Contributor

Release author: @f0rmiga.

Automated by Publish to BCR.

@google-cla
Copy link
Copy Markdown

google-cla bot commented Aug 22, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@rickeylev
Copy link
Copy Markdown
Contributor

rickeylev commented Aug 22, 2023

Weird that the CLA check is failing. I can see it as signed in our CLA bot checker page.

Maybe it's because the commit is using <th***o​@aspect.dev> instead of the email CLA bot has for the github user?

@f0rmiga
Copy link
Copy Markdown
Contributor

f0rmiga commented Aug 22, 2023

@rickeylev yeah, I'm not with Aspect anymore so that email won't work.

@f0rmiga
Copy link
Copy Markdown
Contributor

f0rmiga commented Aug 22, 2023

I don't recall where we should change the email the bot uses to publish here. Do you recall?

@Wyverald
Copy link
Copy Markdown
Member

Signed-off-by: Thulio Ferraz Assis <3149049+f0rmiga@users.noreply.github.com>
@f0rmiga f0rmiga force-pushed the bazelbuild/rules_python@0.25.0-f71915b0 branch from 88ec140 to 7cf114d Compare August 22, 2023 22:16
github-merge-queue bot pushed a commit to bazel-contrib/rules_python that referenced this pull request Aug 22, 2023
Fixes bazelbuild/bazel-central-registry#863.

The aspect email is no longer associated with the github user, so the
CLA bot but doesn't
think think the CLA is signed. To fix, change the email the BCR PRs are
published under
to an address that is associated with the github user (and thus the
CLA).
@f0rmiga
Copy link
Copy Markdown
Contributor

f0rmiga commented Aug 22, 2023

@rickeylev You closed this by using the fixes keyword on the rules_python PR. This needs to be reopened.

@Wyverald
Copy link
Copy Markdown
Member

I think you need to push a new PR anyway, unless you can somehow retroactively fix the email associated with the commit.

@rickeylev rickeylev reopened this Aug 22, 2023
@Wyverald
Copy link
Copy Markdown
Member

oh, it is fixed already. IDK how that worked, but happy to approve :)

@rickeylev
Copy link
Copy Markdown
Contributor

The PR was force-pushed to rewrite the commit's email, so CLA bot is happy with it now

@Wyverald Wyverald merged commit b9abef7 into bazelbuild:main Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants