Skip to content

com_github_rabbitmq_osiris@1.6.3#840

Merged
fmeum merged 1 commit intobazelbuild:mainfrom
rabbitmq:rabbitmq/osiris@v1.6.3-5c1f2b59
Aug 15, 2023
Merged

com_github_rabbitmq_osiris@1.6.3#840
fmeum merged 1 commit intobazelbuild:mainfrom
rabbitmq:rabbitmq/osiris@v1.6.3-5c1f2b59

Conversation

@publish-to-bcr-bot
Copy link
Copy Markdown
Contributor

Release author: @pjk25.

Automated by Publish to BCR.

@fmeum fmeum enabled auto-merge (squash) August 15, 2023 12:34
@fmeum fmeum merged commit 472e4e7 into bazelbuild:main Aug 15, 2023
@HoloRin HoloRin deleted the rabbitmq/osiris@v1.6.3-5c1f2b59 branch August 15, 2023 12:42
@Wyverald
Copy link
Copy Markdown
Member

IMO rabbitmq_osiris would've been a better name, and you can use module(..., repo_name="com_github_rabbitmq_osiris") if you need to keep the old name around. We generally don't do the reverse domain name thing in BCR.

@HoloRin
Copy link
Copy Markdown
Contributor

HoloRin commented Aug 16, 2023

IMO rabbitmq_osiris would've been a better name

That's good to know. Since the BCR is flat, we wanted to be respectful and not just grab "osiris" as a top level name. Osiris is from the rabbitmq github org, but is meant for use outside of rabbitmq/rabbitmq as well. I'm about to add another project of ours called ra. Maybe an appropriate name would be "ra-erlang"?

@HoloRin
Copy link
Copy Markdown
Contributor

HoloRin commented Aug 17, 2023

@Wyverald I used rabbitmq_ra for https://github.com/rabbitmq/ra in #846

Should we consider renaming this module to rabbitmq_osiris? Or leave it as it is?

@Wyverald
Copy link
Copy Markdown
Member

Osiris is from the rabbitmq github org, but is meant for use outside of rabbitmq/rabbitmq as well. I'm about to add another project of ours called ra. Maybe an appropriate name would be "ra-erlang"?

I think calling it rabbitmq_ra (like you did) is perfectly reasonable; it doesn't mean it needs to be used by rabbitmq only, just that it's under the rabbitmq org (similar to google_benchmark not being used for google only, for example).

Regarding renaming, I think we could actually get away with renaming it since it was submitted 2 days ago and unlikely to have seen a lot of usage yet. Happy to force-approve the PR if you send it, but ultimately I'll leave it up to you, since you're likely the only user of that module right now :)

@HoloRin
Copy link
Copy Markdown
Contributor

HoloRin commented Aug 17, 2023

Yes, probably we are the only user, I will first open a PR with the new name, then a second PR to remove the old entry once our references have been updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants