Skip to content

Add protobuf 34.0.bcr.1#7785

Merged
dzbarsky merged 4 commits intomainfrom
ks/test-protobuf-with-patch
Mar 5, 2026
Merged

Add protobuf 34.0.bcr.1#7785
dzbarsky merged 4 commits intomainfrom
ks/test-protobuf-with-patch

Conversation

@keith
Copy link
Copy Markdown
Member

@keith keith commented Mar 3, 2026

Exactly the same as 34.0 but patches in protocolbuffers/protobuf#26173

@keith keith added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Mar 3, 2026
@bazel-io
Copy link
Copy Markdown
Member

bazel-io commented Mar 3, 2026

Hello @protobuf-team-bot, @zhangskz, @mkruskal-google, @googleberg, modules you maintain (protobuf) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

keith added 3 commits March 3, 2026 13:37
This reverts commit db9498f83871c836cd24e14d2a2e9dd5590da764.
@keith keith changed the title Test protobuf with patch Add protobuf 34.0.bcr.1 Mar 3, 2026
@keith keith marked this pull request as ready for review March 3, 2026 22:32
@keith
Copy link
Copy Markdown
Member Author

keith commented Mar 3, 2026

@dzbarsky dzbarsky merged commit d0e75ca into main Mar 5, 2026
26 checks passed
module(
name = "protobuf",
version = "34.0.bcr.1", # Automatically updated on release
bazel_compatibility = [">=7.2.1"],
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note @keith I think you introduced this constraint (didn't appear in previous 34.0 entry)

see
protocolbuffers/protobuf#26331

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yea just required for using overlays. since they said they actually dropped bazel 7 support I'm hoping it's not an issue? https://protobuf.dev/support/migration/

ileitch pushed a commit to ileitch/bazel-central-registry that referenced this pull request Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants