Closed
Conversation
katre
approved these changes
Aug 1, 2019
Collaborator
katre
left a comment
There was a problem hiding this comment.
LGTM. Rebase onto master so the extra changes don't show up.
Member
Author
|
The fix for the test has a bug, will handle it on the internal import side of things. |
These will be used by third_party/protobuf in a follow-up. Also update a test that uses protobuf and that will break when protobuf is updated (since the test can't be changed in the same PR as third_party/). Break-out of bazelbuild#9019. Work toward bazelbuild#9006. RELNOTES: None
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Next breakout of #9019. Will rebase after #9044 is merged. Manually triggered CI run here. (Hope I'm not slowing down our Buildkite by doing these manual runs, but I want monotonic CI progress, and updating these PRs kills our CI runs.)