Add stub @rules_python to third_party/#9044
Closed
brandjon wants to merge 2 commits intobazelbuild:masterfrom
Closed
Add stub @rules_python to third_party/#9044brandjon wants to merge 2 commits intobazelbuild:masterfrom
brandjon wants to merge 2 commits intobazelbuild:masterfrom
Conversation
This stub contains only one relevant file, @rules_python//python:defs.bzl, which mimics the file at the same path in bazelbuild/rules_python. Having this repo gives us a way to inject this defs.bzl file into our protobuf dependency, which is loaded as a separate (local) external repo and therefore cannot access the existing //tools/python:private/defs.bzl in Bazel's own workspace. It also means we'll be compatible with the future upstream migration to fix protobuf for bazelbuild#9006. A separate PR will add this to the Bazel root WORKSPACE file (since third_party/ must be updated in a separate commit). Break-out of bazelbuild#9019. Work toward bazelbuild#9006. RELNOTES: None
katre
suggested changes
Aug 1, 2019
katre
reviewed
Aug 1, 2019
Member
Author
|
Update from offline discussions: Visibility is fixed in most recent commit but we're confirming CI passes. (Turns out my workstation failed bootstrapping tests because of low disk space.) Buildkite testing this commit without visibility fix (in addition to the one auto-triggered by this PR) Buildkite testing this commit with visibility fix |
Closed
Member
Author
|
Passed in manual CI run of branch containing this PR's content. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This stub contains only one relevant file, @rules_python//python:defs.bzl,
which mimics the file at the same path in bazelbuild/rules_python. Having this
repo gives us a way to inject this defs.bzl file into our protobuf dependency,
which is loaded as a separate (local) external repo and therefore cannot access
the existing //tools/python:private/defs.bzl in Bazel's own workspace. It also
means we'll be compatible with the future upstream migration to fix protobuf
for #9006.
A separate PR will add this to the Bazel root WORKSPACE file (since
third_party/ must be updated in a separate commit).
Break-out of #9019. Work toward #9006.
RELNOTES: None