Partially revert "Make download cache entries read-only" #28148
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This partially reverts commit 65fe463. Breaks repo rules that hit a download cache entry and subsequently attempt to overwrite the file (e.g. http_archive's handling of remote module files). The test is kept as it doesn't depend on the change.
Member
|
@bazel-io fork 8.5.1 |
Member
|
@bazel-io fork 8.6.0 |
Member
|
@bazel-io fork 9.0.0 |
This was referenced Jan 5, 2026
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Jan 5, 2026
This reverts commit 65fe463. Breaks repo rules that hit a download cache entry and subsequently attempt to overwrite the file (e.g. http_archive's handling of remote module files). Keeps the added test as it doesn't depend on the change. Work towards bazelbuild#28031 Closes bazelbuild#28148. PiperOrigin-RevId: 852373210 Change-Id: I9e5e9ae87696068fbcb41cfd4dc77c36fea8248b
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Jan 5, 2026
This reverts commit 65fe463. Breaks repo rules that hit a download cache entry and subsequently attempt to overwrite the file (e.g. http_archive's handling of remote module files). Keeps the added test as it doesn't depend on the change. Work towards bazelbuild#28031 Closes bazelbuild#28148. PiperOrigin-RevId: 852373210 Change-Id: I9e5e9ae87696068fbcb41cfd4dc77c36fea8248b
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Jan 5, 2026
This reverts commit 65fe463. Breaks repo rules that hit a download cache entry and subsequently attempt to overwrite the file (e.g. http_archive's handling of remote module files). Keeps the added test as it doesn't depend on the change. Work towards bazelbuild#28031 Closes bazelbuild#28148. PiperOrigin-RevId: 852373210 Change-Id: I9e5e9ae87696068fbcb41cfd4dc77c36fea8248b
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Jan 6, 2026
This reverts commit 65fe463. Breaks repo rules that hit a download cache entry and subsequently attempt to overwrite the file (e.g. http_archive's handling of remote module files). Keeps the added test as it doesn't depend on the change. Work towards bazelbuild#28031 Closes bazelbuild#28148. PiperOrigin-RevId: 852373210 Change-Id: I9e5e9ae87696068fbcb41cfd4dc77c36fea8248b
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 6, 2026
) This reverts commit 65fe463. Breaks repo rules that hit a download cache entry and subsequently attempt to overwrite the file (e.g. http_archive's handling of remote module files). Keeps the added test as it doesn't depend on the change. Work towards #28031 Closes #28148. PiperOrigin-RevId: 852373210 Change-Id: I9e5e9ae87696068fbcb41cfd4dc77c36fea8248b Commit d5dba3f Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
iancha1992
pushed a commit
to iancha1992/bazel
that referenced
this pull request
Jan 6, 2026
…elbuild#28161) This reverts commit 65fe463. Breaks repo rules that hit a download cache entry and subsequently attempt to overwrite the file (e.g. http_archive's handling of remote module files). Keeps the added test as it doesn't depend on the change. Work towards bazelbuild#28031 Closes bazelbuild#28148. PiperOrigin-RevId: 852373210 Change-Id: I9e5e9ae87696068fbcb41cfd4dc77c36fea8248b Commit bazelbuild@d5dba3f Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 6, 2026
) This reverts commit 65fe463. Breaks repo rules that hit a download cache entry and subsequently attempt to overwrite the file (e.g. http_archive's handling of remote module files). Keeps the added test as it doesn't depend on the change. Work towards #28031 Closes #28148. PiperOrigin-RevId: 852373210 Change-Id: I9e5e9ae87696068fbcb41cfd4dc77c36fea8248b Commit d5dba3f Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 65fe463.
Breaks repo rules that hit a download cache entry and subsequently attempt to overwrite the file (e.g. http_archive's handling of remote module files).
Keeps the added test as it doesn't depend on the change.
Work towards #28031