Use internal string encoding for Skycache keys#28117
Closed
fmeum wants to merge 1 commit intobazelbuild:masterfrom
Closed
Use internal string encoding for Skycache keys#28117fmeum wants to merge 1 commit intobazelbuild:masterfrom
fmeum wants to merge 1 commit intobazelbuild:masterfrom
Conversation
All strings in Bazel are coded as raw bytes with a Latin1 coder. Taking advantage of this in `FileDependencyKeySupport#computeCacheKey` avoids double encoding and can avoid some buffer copies.
aoeui
approved these changes
Dec 29, 2025
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Jan 6, 2026
All strings in Bazel are coded as raw bytes with a Latin1 coder. Taking advantage of this in `FileDependencyKeySupport#computeCacheKey` avoids double encoding and can avoid some buffer copies. Closes bazelbuild#28117. PiperOrigin-RevId: 852375819 Change-Id: Ia42d4168a79dc646207ac36a955132280eee2bca
mbland
added a commit
to mbland/bazel
that referenced
this pull request
Jan 8, 2026
Fixes postsubmit job failures after merging bazelbuild#27463 by aligning the `.bazelci` postsubmit jobs with `.bazelci/presubmit.yml`. Specifically: - Disabled Android setup and test targets due to infrastructure changes (including but not limited to bazelbuild/continuous-integration#2408). - Updated the `ubuntu2004` jobs to `ubuntu2004_java11` (not that it should matter after the `*_for_testing` repo fix from bazelbuild#27463). - Updated the `xcode_version` of `macos` jobs. Contains other touch-ups to synchronize build images, build flags, test flags, and test targets, as well as to make minor formatting changes. Produced most changes via: `vimdiff .bazelci/p{re,ost}submit.yml`. The remaining differences are: - No sharding in postsubmit jobs. - Setting `--noremote_accept_cached` in postsubmit jobs - Including `include_json_profile` blocks in postsubmit jobs. - The `kythe_ubuntu2004` job sets `index_upload_gcs` to `False` in presubmit and `True` in postsubmit. - The `docs_ubuntu1804` job only exists in presubmit. Part of bazelbuild#28117.
meteorcloudy
pushed a commit
that referenced
this pull request
Jan 9, 2026
Fixes postsubmit job failures after merging #27463 by aligning the `.bazelci` postsubmit jobs with `.bazelci/presubmit.yml`. Specifically: - Disabled Android setup and test targets due to infrastructure changes (including but not limited to bazelbuild/continuous-integration#2408). - Updated the `ubuntu2004` jobs to `ubuntu2004_java11` (not that it should matter after the `*_for_testing` repo fix from #27463). - Updated the `xcode_version` of `macos` jobs. Contains other touch-ups to synchronize build images, build flags, test flags, and test targets, as well as to make minor formatting changes. Produced most changes via: `vimdiff .bazelci/p{re,ost}submit.yml`. The remaining differences are: - No sharding in postsubmit jobs. - Setting `--noremote_accept_cached` in postsubmit jobs - Including `include_json_profile` blocks in postsubmit jobs. - The `kythe_ubuntu2004` job sets `index_upload_gcs` to `False` in presubmit and `True` in postsubmit. - The `docs_ubuntu1804` job only exists in presubmit. Part of #28117.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All strings in Bazel are coded as raw bytes with a Latin1 coder. Taking advantage of this in
FileDependencyKeySupport#computeCacheKeyavoids double encoding and can avoid some buffer copies.