Enable --experimental_retain_test_configuration_across_testonly
#28073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--incompatible_check_testonly_for_output_files and incompatible_retain_test_configuration_across_testonly--incompatible_check_testonly_for_output_files and --incompatible_retain_test_configuration_across_testonly
--incompatible_check_testonly_for_output_files and --incompatible_retain_test_configuration_across_testonly--incompatible_retain_test_configuration_across_testonly by default
--incompatible_retain_test_configuration_across_testonly by default--experimental_retain_test_configuration_across_testonly
Collaborator
Author
|
@bazel-io fork 9.0.0 |
gregestren
approved these changes
Dec 22, 2025
Contributor
gregestren
left a comment
There was a problem hiding this comment.
Added prerequisite change to Google's bazerlc to keep false at cl/847799241.
We'll be able to merge when that's submitted. I'll be offline after today til the new year but @dabanki 's also paying attention.
dabanki
approved these changes
Dec 22, 2025
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Dec 22, 2025
This avoids action conflicts when `testonly` non-test targets depend on test targets. Until `--incompatible_check_testonly_for_output_files` is flipped, it is still possible to get action conflicts when a non-`testonly` target depends on an output file of a test. Since this can be fixed by adding the missing `testonly` annotation, this is only a minor concern. Fixes bazelbuild#28056 Closes bazelbuild#28073. PiperOrigin-RevId: 847892897 Change-Id: I60e908a22b51c307306760aa054b3968cfbebac2
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Dec 29, 2025
This avoids action conflicts when `testonly` non-test targets depend on test targets. Until `--incompatible_check_testonly_for_output_files` is flipped, it is still possible to get action conflicts when a non-`testonly` target depends on an output file of a test. Since this can be fixed by adding the missing `testonly` annotation, this is only a minor concern. Fixes bazelbuild#28056 Closes bazelbuild#28073. PiperOrigin-RevId: 847892897 Change-Id: I60e908a22b51c307306760aa054b3968cfbebac2
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Dec 29, 2025
This avoids action conflicts when `testonly` non-test targets depend on test targets. Until `--incompatible_check_testonly_for_output_files` is flipped, it is still possible to get action conflicts when a non-`testonly` target depends on an output file of a test. Since this can be fixed by adding the missing `testonly` annotation, this is only a minor concern. Fixes bazelbuild#28056 Closes bazelbuild#28073. PiperOrigin-RevId: 847892897 Change-Id: I60e908a22b51c307306760aa054b3968cfbebac2
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 5, 2026
…nly` (#28116) This avoids action conflicts when `testonly` non-test targets depend on test targets. Until `--incompatible_check_testonly_for_output_files` is flipped, it is still possible to get action conflicts when a non-`testonly` target depends on an output file of a test. Since this can be fixed by adding the missing `testonly` annotation, this is only a minor concern. Fixes #28056 Closes #28073. PiperOrigin-RevId: 847892897 Change-Id: I60e908a22b51c307306760aa054b3968cfbebac2 Commit bcd8bcb Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 5, 2026
…nly` (#28115) This avoids action conflicts when `testonly` non-test targets depend on test targets. Until `--incompatible_check_testonly_for_output_files` is flipped, it is still possible to get action conflicts when a non-`testonly` target depends on an output file of a test. Since this can be fixed by adding the missing `testonly` annotation, this is only a minor concern. Fixes #28056 Closes #28073. PiperOrigin-RevId: 847892897 Change-Id: I60e908a22b51c307306760aa054b3968cfbebac2 Commit bcd8bcb Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 7, 2026
…nly` (#28089) This avoids action conflicts when `testonly` non-test targets depend on test targets. Until `--incompatible_check_testonly_for_output_files` is flipped, it is still possible to get action conflicts when a non-`testonly` target depends on an output file of a test. Since this can be fixed by adding the missing `testonly` annotation, this is only a minor concern. Fixes #28056 Closes #28073. PiperOrigin-RevId: 847892897 Change-Id: I60e908a22b51c307306760aa054b3968cfbebac2 Commit bcd8bcb Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids action conflicts when
testonlynon-test targets depend on test targets.Until
--incompatible_check_testonly_for_output_filesis flipped, it is still possible to get action conflicts when a non-testonlytarget depends on an output file of a test. Since this can be fixed by adding the missingtestonlyannotation, this is only a minor concern.Fixes #28056