Forward --host_jvmopt to the exec configuration#26346
Closed
fmeum wants to merge 2 commits intobazelbuild:masterfrom
Closed
Forward --host_jvmopt to the exec configuration#26346fmeum wants to merge 2 commits intobazelbuild:masterfrom
--host_jvmopt to the exec configuration#26346fmeum wants to merge 2 commits intobazelbuild:masterfrom
Conversation
Contributor
|
LGTM but did any recent user-facing behavior motivate this? #15978 was from before the And from #15978 (comment):
I don't think this kind of change is harmful either way. Just want to understand the context. |
Collaborator
Author
|
You are right, this is no longer motivated by action conflicts. I still think it's needed for correctness in an exec -> jvmopts -> exec transition scenario, however unlikely that may be in practice. |
gregestren
approved these changes
Jun 20, 2025
Collaborator
Author
|
@bazel-io fork 8.4.0 |
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Jul 1, 2025
This ports bazelbuild#15978, which never got merged, to Starlark. Closes bazelbuild#26346. PiperOrigin-RevId: 777732082 Change-Id: I699c8fc248d18e1e6db168725f49fc051829b45e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ports #15978, which never got merged, to Starlark.