Overlay the registry MODULE.bazel file on the module repo#26332
Closed
fmeum wants to merge 10 commits intobazelbuild:masterfrom
Closed
Overlay the registry MODULE.bazel file on the module repo#26332fmeum wants to merge 10 commits intobazelbuild:masterfrom
MODULE.bazel file on the module repo#26332fmeum wants to merge 10 commits intobazelbuild:masterfrom
Conversation
82b693d to
66d4bf1
Compare
Member
|
So even if the source archive already contains a MODULE.bazel, it'll still be overridden by the one from the registry, right? If we do this, we probably have to also backport to both bazel 7 and 8. Even with that, I'm just a bit concerned if we loose up the restriction on BCR side, there might be unexpected problems for users not using latest minor versions of Bazel 7 & 8? @Wyverald WDYT? |
Collaborator
Author
|
Yes, but for existing registry versions we've verified that both agree. That won't necessarily be true for custom registries though. We could decide to loosen restrictions later, say when Bazel 9 is out. |
Wyverald
approved these changes
Jul 1, 2025
src/main/java/com/google/devtools/build/lib/bazel/bzlmod/Registry.java
Outdated
Show resolved
Hide resolved
src/test/java/com/google/devtools/build/lib/bazel/bzlmod/IndexRegistryTest.java
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
@bazel-io fork 8.4.0 |
meteorcloudy
approved these changes
Jul 1, 2025
Member
meteorcloudy
left a comment
There was a problem hiding this comment.
Ah, if we delay the loosing of BCR restriction to Bazel 9, then I have no concern!
iancha1992
pushed a commit
to iancha1992/bazel
that referenced
this pull request
Jul 2, 2025
RELNOTES: Modules backed by `http_archive` or `git_repository` no longer require a MODULE.bazel file to be contained in the source archive. Fixes bazelbuild#26217 Closes bazelbuild#26332. PiperOrigin-RevId: 778139801 Change-Id: Ie1d219ce1c219c8bae7657be929e54b9b467abf9
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 8, 2025
…26462) RELNOTES: Modules backed by `http_archive` or `git_repository` no longer require a MODULE.bazel file to be contained in the source archive. Fixes #26217 Closes #26332. PiperOrigin-RevId: 778139801 Change-Id: Ie1d219ce1c219c8bae7657be929e54b9b467abf9 Commit c5a562b --------- Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
Member
|
@bazel-io fork 7.7.0 |
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Oct 9, 2025
RELNOTES: Modules backed by `http_archive` or `git_repository` no longer require a MODULE.bazel file to be contained in the source archive. Fixes bazelbuild#26217 Closes bazelbuild#26332. PiperOrigin-RevId: 778139801 Change-Id: Ie1d219ce1c219c8bae7657be929e54b9b467abf9 (cherry picked from commit c5a562b)
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Oct 9, 2025
RELNOTES: Modules backed by `http_archive` or `git_repository` no longer require a MODULE.bazel file to be contained in the source archive. Fixes bazelbuild#26217 Closes bazelbuild#26332. PiperOrigin-RevId: 778139801 Change-Id: Ie1d219ce1c219c8bae7657be929e54b9b467abf9 (cherry picked from commit c5a562b)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 10, 2025
…27216) RELNOTES: Modules backed by `http_archive` or `git_repository` no longer require a MODULE.bazel file to be contained in the source archive. Fixes #26217 Closes #26332. PiperOrigin-RevId: 778139801 Change-Id: Ie1d219ce1c219c8bae7657be929e54b9b467abf9 (cherry picked from commit c5a562b) Closes #26983
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RELNOTES: Modules backed by
http_archiveorgit_repositoryno longer require a MODULE.bazel file to be contained in the source archive.Fixes #26217