stop assuming default target provider fields in tests#26297
Closed
dws wants to merge 1 commit intobazelbuild:masterfrom
Closed
stop assuming default target provider fields in tests#26297dws wants to merge 1 commit intobazelbuild:masterfrom
dws wants to merge 1 commit intobazelbuild:masterfrom
Conversation
We here take a stab at modernizing the test code in Bazel to be compatible with flipping the default for the flag `--incompatible_disable_target_default_provider_fields`.
Contributor
Author
|
@meteorcloudy Perhaps you could select a reviewer for this? |
meteorcloudy
approved these changes
Jun 16, 2025
copybara-service Bot
pushed a commit
that referenced
this pull request
Jun 17, 2025
…der_fields We here address obstacles to building Bazel with `--incompatible_disable_target_default_provider_fields` enabled. This includes patches representing - bazelbuild/apple_support#413 - bazelbuild/rules_java#303 - grpc/grpc-java#12148 which should be removed once these PRs have been included in releases of their respective repos. All of these pull requests have been approved and merged into their respective repositories. Once #26276 is cherry-picked into a Bazel 8 release, we should be able to update `.bazelversion` to that release, and in conjunction with the changes herein, we should be able to enable `--incompatible_disable_target_default_provider_fields` in `.bazelrc` in order to prevent regressions. Ideally, we could also flip the default value of this flag once #26297 also lands. Note that #26293 is related, but not strictly needed for builds. Closes #26272. PiperOrigin-RevId: 772542631 Change-Id: Ib5db3ffa3f4857199a6f8d838078d7ced2281ba3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We here take a stab at modernizing the test code in Bazel to be compatible with flipping the default for the flag
--incompatible_disable_target_default_provider_fields.