Skip to content

Fix and document coverage support for test rules #25996

Closed
fmeum wants to merge 1 commit intobazelbuild:masterfrom
fmeum:add-implicit-coverage-deps
Closed

Fix and document coverage support for test rules #25996
fmeum wants to merge 1 commit intobazelbuild:masterfrom
fmeum:add-implicit-coverage-deps

Conversation

@fmeum
Copy link
Copy Markdown
Collaborator

@fmeum fmeum commented May 4, 2025 •
edited
Loading

The LCOV merger needs to be able to run on the test action's execution platform.

@fmeum fmeum force-pushed the add-implicit-coverage-deps branch 3 times, most recently from ebafe03 to 1502549 Compare May 4, 2025 09:35
@fmeum fmeum changed the title Automatically add _lcov_merger and _collect_cc_coverage attributes Fix and document coverage support for test rules May 4, 2025
@fmeum
Fix and document coverage support for test rules
1d3a2e5 
The LCOV merger needs to be able to run on the test action's execution platform.
@fmeum fmeum force-pushed the add-implicit-coverage-deps branch from 1502549 to 1d3a2e5 Compare May 4, 2025 09:45
@fmeum fmeum marked this pull request as ready for review May 4, 2025 09:50
@fmeum fmeum requested review from fweikert and gregestren as code owners May 4, 2025 09:50
@fmeum fmeum requested a review from c-mita May 4, 2025 09:50
@github-actions github-actions bot added team-Documentation Documentation improvements that cannot be directly linked to other team labels awaiting-review PR is awaiting review from an assigned reviewer labels May 4, 2025
@fmeum fmeum mentioned this pull request May 4, 2025
Merged
@iancha1992 iancha1992 added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label May 6, 2025
@meteorcloudy
Copy link
Copy Markdown
Member

meteorcloudy commented May 13, 2025

@c-mita Can you take a look?

@meteorcloudy
Copy link
Copy Markdown
Member

meteorcloudy commented May 20, 2025

Ping @c-mita

@c-mita c-mita added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels May 21, 2025
@fmeum
Copy link
Copy Markdown
Collaborator Author

fmeum commented May 21, 2025

@bazel-io fork 8.3.0

@bazel-io bazel-io mentioned this pull request May 21, 2025
Closed
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label May 21, 2025
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request May 21, 2025
@fmeum @bazel-io
Fix and document coverage support for test rules
d3bb622 
The LCOV merger needs to be able to run on the test action's execution platform.

Closes bazelbuild#25996.

PiperOrigin-RevId: 7616358
Change-Id: Idfd35f3fdb389e57066ad22487432a6571c3eba1
@bazel-io bazel-io mentioned this pull request May 21, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request May 27, 2025
@bazel-io @fmeum
[8.3.0] Fix and document coverage support for test rules (#26122)
c0fc7ba 
The LCOV merger needs to be able to run on the test action's execution
platform.

Closes #25996.

PiperOrigin-RevId: 7616358
Change-Id: Idfd35f3fdb389e57066ad22487432a6571c3eba1

Commit
13f1646

Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@c-mita c-mita c-mita approved these changes

@gregestren gregestren Awaiting requested review from gregestren gregestren is a code owner

@fweikert fweikert Awaiting requested review from fweikert fweikert is a code owner

Assignees

No one assigned

Labels

team-Documentation Documentation improvements that cannot be directly linked to other team labels team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fmeum @meteorcloudy @c-mita @iancha1992