Move incompatible_macos_set_install_name to graveyard#25682
Closed
keith wants to merge 1 commit intobazelbuild:masterfrom
Closed
Move incompatible_macos_set_install_name to graveyard#25682keith wants to merge 1 commit intobazelbuild:masterfrom
keith wants to merge 1 commit intobazelbuild:masterfrom
Conversation
keith
added a commit
to bazelbuild/apple_support
that referenced
this pull request
Mar 24, 2025
keith
added a commit
to keith/rules_cc
that referenced
this pull request
Mar 24, 2025
keith
commented
Mar 24, 2025
| @@ -933,7 +933,7 @@ public boolean getExperimentalCppCompileResourcesEstimation() { | |||
|
|
|||
| @Override | |||
| public boolean macosSetInstallName() { | |||
Member
Author
There was a problem hiding this comment.
seems like we have to keep this for a bit otherwise everyone will break until they update rules_cc bazelbuild/rules_cc#379 / apple_support bazelbuild/apple_support#378
43a0870 to
1da18a5
Compare
This was flipped in 8.x. The other TODO is now something we should do in rules_cc when it drops 7.x support
1da18a5 to
b6676e7
Compare
Contributor
|
Thanks! |
lberki
approved these changes
Mar 26, 2025
keith
added a commit
to bazelbuild/apple_support
that referenced
this pull request
Mar 27, 2025
keith
added a commit
to bazelbuild/apple_support
that referenced
this pull request
Mar 28, 2025
fmeum
pushed a commit
to fmeum/bazel
that referenced
this pull request
Apr 25, 2025
This was flipped in 8.x. The other TODO is now something we should do in rules_cc when it drops 7.x support Closes bazelbuild#25682. PiperOrigin-RevId: 740728603 Change-Id: Ied89f06dba776a749f9026aff41584befb197ebc
copybara-service bot
pushed a commit
to bazelbuild/rules_cc
that referenced
this pull request
Sep 8, 2025
Copybara Import from #379 BEGIN_PUBLIC Support eventual removal of do_not_use_macos_set_install_name (#379) bazelbuild/bazel#25682 Closes #379 END_PUBLIC COPYBARA_INTEGRATE_REVIEW=#379 from keith:ks/support-eventual-removal-of-do_not_use_macos_set_install_name a5a6638 PiperOrigin-RevId: 804585431 Change-Id: I9c2ddb82de4fa41cea34443e819f71de06073da0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was flipped in 8.x. The other TODO is now something we should do in
rules_cc when it drops 7.x support