Closed
Conversation
Member
Author
|
cc @meteorcloudy re e531e7b |
Member
|
@keith Do you have time to take a look at fixing the tests? |
6a32d32 to
7a8d59d
Compare
5116db4 to
ae0d727
Compare
ae0d727 to
2ad86c5
Compare
apple_support and rules_cc have their own copies of this. Anyone still relying on this should update those rules.
2ad86c5 to
ffd1a93
Compare
Member
Author
|
thanks, that lead to quite the rabbit hole. green now! |
meteorcloudy
approved these changes
Apr 1, 2025
Member
meteorcloudy
left a comment
There was a problem hiding this comment.
Thank you so much for digging into this!
fmeum
pushed a commit
to fmeum/bazel
that referenced
this pull request
Apr 25, 2025
apple_support and rules_cc have their own copies of this. Anyone still relying on this should update those rules. Closes bazelbuild#25681. PiperOrigin-RevId: 743050086 Change-Id: Ie375152cd57f9f1f50b50552f2f12230c0135179
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
apple_support and rules_cc have their own copies of this. Anyone still
relying on this should update those rules.