Track getenv calls in module extensions#22498
Track getenv calls in module extensions#22498fmeum wants to merge 2 commits intobazelbuild:masterfrom
getenv calls in module extensions#22498Conversation
4dbe81f to
9c7f487
Compare
| } | ||
| } | ||
| }, | ||
| "moduleExtensionMetadata": null, |
There was a problem hiding this comment.
Not sure how we feel about null values popping up here.
There was a problem hiding this comment.
Can you explain a bit why null ended up here?
There was a problem hiding this comment.
That's because of
https://github.com/bazelbuild/bazel/pull/22498/files#diff-11c1c9cda0a3bafa6f377878111faecc4be3f83ac0a74fe9115f3cb297d78bf2R251
I could add a dedicated type adapter for Optional<String> to prevent this from happening for other Optional<T>. What do you think?
There was a problem hiding this comment.
Yeah, I think that would be a cleaner solution?
|
Tests should be passing now. This was unreasonably annoying due to having to deal with |
ab1569c to
563742a
Compare
|
@bazel-io fork 7.2.0 |
|
@meteorcloudy The merge commit broke the lock file, should I force push a fix or are you taking care of that during import? |
|
We indeed had some trouble merging this one, updating this PR would definitely help! @iancha1992 |
RELNOTES: Changes to environment variables read via `getenv` now correctly invalidate module extensions.
|
@meteorcloudy Should be resolved |
Fixes #22404
RELNOTES: Changes to environment variables read via
getenvnow correctly invalidate module extensions.