Skip to content

[7.2.0] Update @rules_java v7.6.1#22480

Merged
iancha1992 merged 4 commits intorelease-7.2.0from
wyv-720-rj
May 22, 2024
Merged

[7.2.0] Update @rules_java v7.6.1#22480
iancha1992 merged 4 commits intorelease-7.2.0from
wyv-720-rj

Conversation

@Wyverald
Copy link
Copy Markdown
Member

@Wyverald Wyverald commented May 21, 2024

No description provided.

Wyverald and others added 2 commits May 21, 2024 17:14
@Wyverald @hvadehra
Update @rules_java v7.6.1
d8946e8 
Closes #22430.

Co-authored-by: hvd <hvadehra@gmail.com>
PiperOrigin-RevId: 635920357
Change-Id: I2ce7155ddb8d544f40a1940a1b44dfee8d2af5a7
@Wyverald
update lockfiles
c112448
@Wyverald Wyverald requested a review from a team as a code owner May 21, 2024 21:23
@google-cla
Copy link
Copy Markdown

google-cla bot commented May 21, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Wyverald Wyverald mentioned this pull request May 21, 2024
Closed
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label May 21, 2024
@iancha1992 iancha1992 added the team-Rules-Java Issues for Java rules label May 21, 2024
@iancha1992 iancha1992 enabled auto-merge May 21, 2024 21:30
@Wyverald
Copy link
Copy Markdown
Member Author

Wyverald commented May 21, 2024

@hvadehra there's a crapton of these failures on CI:

com.google.devtools.build.lib.skyframe.BzlLoadFunction$BzlLoadFunctionException: com.google.devtools.build.lib.skyframe.BzlLoadFunction$BzlLoadFailedException: Label '@@rules_java~//java/common:java_common.bzl' is invalid because 'java/common' is not a package; perhaps you meant to put the colon here: '@@rules_java~//java:common/java_common.bzl'?
	at com.google.devtools.build.lib.skyframe.BzlLoadFunction.compute(BzlLoadFunction.java:199)
	at com.google.devtools.build.skyframe.AbstractParallelEvaluator$Evaluate.run(AbstractParallelEvaluator.java:461)
	at com.google.devtools.build.lib.concurrent.AbstractQueueVisitor$WrappedRunnable.run(AbstractQueueVisitor.java:414)
	at java.base/java.util.concurrent.ForkJoinTask$AdaptedRunnableAction.exec(ForkJoinTask.java:1403)
	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:387)
	at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1312)
	at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1843)
	at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1808)
	at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:188)
Caused by: com.google.devtools.build.lib.skyframe.BzlLoadFunction$BzlLoadFailedException: Label '@@rules_java~//java/common:java_common.bzl' is invalid because 'java/common' is not a package; perhaps you meant to put the colon here: '@@rules_java~//java:common/java_common.bzl'?
	at com.google.devtools.build.lib.skyframe.BzlLoadFunction$BzlLoadFailedException.labelCrossesPackageBoundary(BzlLoadFunction.java:1660)
	at com.google.devtools.build.lib.skyframe.BzlLoadFunction.validatePackageAndGetCompileKey(BzlLoadFunction.java:691)
	at com.google.devtools.build.lib.skyframe.BzlLoadFunction.computeInternal(BzlLoadFunction.java:545)
	at com.google.devtools.build.lib.skyframe.BzlLoadFunction.compute(BzlLoadFunction.java:197)
	... 8 more

Did I miss something during the cherry-pick? The PR was fine on master.

@hvadehra
Copy link
Copy Markdown
Member

hvadehra commented May 22, 2024

I think it's just the unit tests setup. Likely we just need 999762d and just the test setup bits from 20c49b4

hvadehra added 2 commits May 22, 2024 14:05
@hvadehra @Wyverald
Prepare Bazel unit tests for loading top-level symbols from rules_java
f352516 
PiperOrigin-RevId: 623470267
Change-Id: I203929d7a3f8626aba71c6f1af7d1df82096b37e
@hvadehra @Wyverald
LSC(tp): Add load() statements for the builtin top-level java symbols
bf8577c 
BEGIN_PUBLIC

Add `load()` statements for the Bazel builtin top-level java symbols

Loads are being added in preparation for moving the symbols out of Bazel and into `rules_java`.

END_PUBLIC

PiperOrigin-RevId: 624087139
Change-Id: I3d98ec19cf1c2cd7e587e4a3e6117c49d7ffd2e8
@iancha1992 iancha1992 added this pull request to the merge queue May 22, 2024
Merged via the queue into release-7.2.0 with commit 84525a0 May 22, 2024
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label May 22, 2024
@Wyverald Wyverald deleted the wyv-720-rj branch May 22, 2024 20:57
hopez13 pushed a commit to hopez13/kernel-superproject that referenced this pull request Dec 26, 2024
@jacky8hyf
Revert "kleaf: Bazel update to 7.2.0rc1"
860c1ce 
This reverts commit 651d0913be7550fd6b9f77ee268124c01f17c924.

Reason for revert: There have been enough issues of 7.2.0rc2,
mainly due to
bazelbuild/bazel#22407
([7.2.0] Preserve paths under hermetic /tmp in the sandbox),
including:
- Kythe was broken (b/343803993)
- Reproducibility is broken because realpath changes (b/345452375, WIP b/346559442)

and due to bazelbuild/bazel#22480
([7.2.0] Update @rules_java v7.6.1):
- docs_dist broken (WIP b/345143232)

To avoid stability issues, and because the non
rc 7.2.0 won't have enough time to settle down,
reverting back to the stabler 7.1.1.

This change is part of the rollback.

Bug: 345143232
Bug: 343803993
Bug: 345452375
Bug: 346559442
Change-Id: Ic90004e2b9011f4d56ada7fd9f15588c9ef20b95
hopez13 pushed a commit to hopez13/kernel-superproject that referenced this pull request Dec 26, 2024
@jacky8hyf
Revert "kleaf: Bazel update to 7.2.0rc1"
657b247 
This reverts commit 651d0913be7550fd6b9f77ee268124c01f17c924.

Reason for revert: There have been enough issues of 7.2.0rc2,
mainly due to
bazelbuild/bazel#22407
([7.2.0] Preserve paths under hermetic /tmp in the sandbox),
including:
- Kythe was broken (b/343803993)
- Reproducibility is broken because realpath changes (b/345452375, WIP b/346559442)

and due to bazelbuild/bazel#22480
([7.2.0] Update @rules_java v7.6.1):
- docs_dist broken (WIP b/345143232)

To avoid stability issues, and because the non
rc 7.2.0 won't have enough time to settle down,
reverting back to the stabler 7.1.1.

This change is part of the rollback.

Bug: 345143232
Bug: 343803993
Bug: 345452375
Bug: 346559442
Change-Id: Ic90004e2b9011f4d56ada7fd9f15588c9ef20b95
hopez13 pushed a commit to hopez13/kernel-superproject that referenced this pull request Dec 26, 2024
@jacky8hyf
Revert "kleaf: Bazel update to 7.2.0rc1"
48f225b 
This reverts commit 651d0913be7550fd6b9f77ee268124c01f17c924.

Reason for revert: There have been enough issues of 7.2.0rc2,
mainly due to
bazelbuild/bazel#22407
([7.2.0] Preserve paths under hermetic /tmp in the sandbox),
including:
- Kythe was broken (b/343803993)
- Reproducibility is broken because realpath changes (b/345452375, WIP b/346559442)

and due to bazelbuild/bazel#22480
([7.2.0] Update @rules_java v7.6.1):
- docs_dist broken (WIP b/345143232)

To avoid stability issues, and because the non
rc 7.2.0 won't have enough time to settle down,
reverting back to the stabler 7.1.1.

This change is part of the rollback.

Bug: 345143232
Bug: 343803993
Bug: 345452375
Bug: 346559442
Change-Id: Ic90004e2b9011f4d56ada7fd9f15588c9ef20b95
xdevs23 pushed a commit to halogenOS/android_prebuilts_kernel-build-tools that referenced this pull request May 9, 2025
@jacky8hyf
Revert^3 "kleaf: Bazel update to 7.2.0rc2"
19fa2f5 
This reverts commit 744d7b8.

Reason for revert: There have been enough issues of 7.2.0rc2,
mainly due to
bazelbuild/bazel#22407
([7.2.0] Preserve paths under hermetic /tmp in the sandbox),
including:
- Kythe was broken (b/343803993)
- Reproducibility is broken because realpath changes (b/345452375, WIP b/346559442)

and due to bazelbuild/bazel#22480
([7.2.0] Update @rules_java v7.6.1):
- docs_dist broken (WIP b/345143232)

To avoid stability issues, and because the non
rc 7.2.0 won't have enough time to settle down,
reverting back to the stabler 7.1.1.

This change is part of the rollback.

Bug: 345143232
Bug: 343803993
Bug: 345452375
Bug: 346559442
Change-Id: I3e56eb98ac852536b71bd7150f312ec66154894c
xdevs23 pushed a commit to halogenOS/android_prebuilts_kernel-build-tools that referenced this pull request May 9, 2025
@jacky8hyf
Revert "kleaf: Bazel update to 7.2.0rc1"
b46264b 
This reverts commit 651d091.

Reason for revert: There have been enough issues of 7.2.0rc2,
mainly due to
bazelbuild/bazel#22407
([7.2.0] Preserve paths under hermetic /tmp in the sandbox),
including:
- Kythe was broken (b/343803993)
- Reproducibility is broken because realpath changes (b/345452375, WIP b/346559442)

and due to bazelbuild/bazel#22480
([7.2.0] Update @rules_java v7.6.1):
- docs_dist broken (WIP b/345143232)

To avoid stability issues, and because the non
rc 7.2.0 won't have enough time to settle down,
reverting back to the stabler 7.1.1.

This change is part of the rollback.

Bug: 345143232
Bug: 343803993
Bug: 345452375
Bug: 346559442
Change-Id: Ic90004e2b9011f4d56ada7fd9f15588c9ef20b95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iancha1992 iancha1992 iancha1992 approved these changes

Assignees

No one assigned

Labels

team-Rules-Java Issues for Java rules

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Wyverald @hvadehra @iancha1992