Skip to content

Local repo rules in Starlark#21681

Closed
Wyverald wants to merge 1 commit intomasterfrom
wyv-local-repo
Closed

Local repo rules in Starlark#21681
Wyverald wants to merge 1 commit intomasterfrom
wyv-local-repo

Conversation

@Wyverald
Copy link
Copy Markdown
Member

@Wyverald Wyverald commented Mar 13, 2024

Added local_repository and new_local_repository as Starlark repo rules under @bazel_tools//tools/build_defs/repo:local.bzl. They're drop-in replacements for their native counterparts.

Work towards #18285.

RELNOTES: The local_repository and new_local_repository repository rules are now available as Starlark rules under @bazel_tools//tools/build_defs/repo:local.bzl. They are drop-in replacements for their native counterparts, and can be used in module extensions.

@Wyverald Wyverald requested a review from fmeum March 13, 2024 19:51
@github-actions github-actions bot added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. awaiting-review PR is awaiting review from an assigned reviewer labels Mar 13, 2024
@Wyverald Wyverald requested a review from meteorcloudy March 13, 2024 19:52
@Wyverald Wyverald requested a review from lberki as a code owner March 13, 2024 19:52
@Wyverald Wyverald marked this pull request as draft March 13, 2024 20:34
@Wyverald
Copy link
Copy Markdown
Member Author

converting back to draft because of every single unit test failing o,o might sort out today, might not

@Wyverald Wyverald force-pushed the wyv-local-repo branch 2 times, most recently from 28fe71d to 06afb71 Compare March 13, 2024 21:43
@Wyverald Wyverald marked this pull request as ready for review March 13, 2024 22:01
@Wyverald
Copy link
Copy Markdown
Member Author

I removed the part that made local_path_override use this new Starlark implementation of local_repository, as it made our unit tests absolutely flip out and I couldn't fix it quickly. Will do that in a follow-up instead.

Added `local_repository` and `new_local_repository` as Starlark repo rules under `@bazel_tools//tools/build_defs/repo:local.bzl`. They're drop-in replacements for their native counterparts.

Work towards #18285.

RELNOTES: The `local_repository` and `new_local_repository` repository rules are now available as Starlark rules under `@bazel_tools//tools/build_defs/repo:local.bzl`. They are drop-in replacements for their native counterparts, and can be used in module extensions.
@Wyverald Wyverald added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Mar 14, 2024
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Mar 14, 2024
@brentleyjones brentleyjones deleted the wyv-local-repo branch March 15, 2024 12:57
Wyverald added a commit that referenced this pull request Apr 25, 2024
Added `local_repository` and `new_local_repository` as Starlark repo rules under `@bazel_tools//tools/build_defs/repo:local.bzl`. They're drop-in replacements for their native counterparts.

Work towards #18285.

RELNOTES: The `local_repository` and `new_local_repository` repository rules are now available as Starlark rules under `@bazel_tools//tools/build_defs/repo:local.bzl`. They are drop-in replacements for their native counterparts, and can be used in module extensions.

Closes #21681.

PiperOrigin-RevId: 615926923
Change-Id: I0cc7355b011751da23f2a3aa189f120ef177e0fe
Wyverald added a commit that referenced this pull request Apr 29, 2024
Added `local_repository` and `new_local_repository` as Starlark repo rules under `@bazel_tools//tools/build_defs/repo:local.bzl`. They're drop-in replacements for their native counterparts.

Work towards #18285.

RELNOTES: The `local_repository` and `new_local_repository` repository rules are now available as Starlark rules under `@bazel_tools//tools/build_defs/repo:local.bzl`. They are drop-in replacements for their native counterparts, and can be used in module extensions.

Closes #21681.

PiperOrigin-RevId: 615926923
Change-Id: I0cc7355b011751da23f2a3aa189f120ef177e0fe
Wyverald added a commit that referenced this pull request Apr 30, 2024
Added `local_repository` and `new_local_repository` as Starlark repo rules under `@bazel_tools//tools/build_defs/repo:local.bzl`. They're drop-in replacements for their native counterparts.

Work towards #18285.

RELNOTES: The `local_repository` and `new_local_repository` repository rules are now available as Starlark rules under `@bazel_tools//tools/build_defs/repo:local.bzl`. They are drop-in replacements for their native counterparts, and can be used in module extensions.

Closes #21681.

PiperOrigin-RevId: 615926923
Change-Id: I0cc7355b011751da23f2a3aa189f120ef177e0fe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants