Skip to content

Flip --experimental_cc_implementation_deps#19724

Closed
thii wants to merge 1 commit intobazelbuild:masterfrom
thii:t/flip-experimental_cc_implementation_deps
Closed

Flip --experimental_cc_implementation_deps#19724
thii wants to merge 1 commit intobazelbuild:masterfrom
thii:t/flip-experimental_cc_implementation_deps

Conversation

@thii
Copy link
Copy Markdown
Member

@thii thii commented Oct 4, 2023

This allows distributing libraries as source that use
implementation_deps.

@thii thii force-pushed the t/flip-experimental_cc_implementation_deps branch from 1373ef3 to f5f2b58 Compare October 4, 2023 13:30
@thii
Flip --experimental_cc_implementation_deps
59a08f8 
This allows distributing libraries as source that use
`implementation_deps`.
@thii thii force-pushed the t/flip-experimental_cc_implementation_deps branch from f5f2b58 to 59a08f8 Compare October 4, 2023 13:35
@thii thii marked this pull request as ready for review October 4, 2023 22:49
@thii thii requested review from lberki and oquenchil as code owners October 4, 2023 22:49
@github-actions github-actions bot added awaiting-review PR is awaiting review from an assigned reviewer team-Rules-CPP Issues for C++ rules labels Oct 4, 2023
@lberki lberki requested review from buildbreaker2021 and comius and removed request for lberki and oquenchil October 5, 2023 06:22
@buildbreaker2021 buildbreaker2021 self-assigned this Oct 5, 2023
@buildbreaker2021 buildbreaker2021 added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Oct 5, 2023
@copybara-service copybara-service bot closed this in 05787f3 Oct 5, 2023
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Oct 5, 2023
@thii thii deleted the t/flip-experimental_cc_implementation_deps branch October 5, 2023 22:44
@thii
Copy link
Copy Markdown
Member Author

thii commented Oct 6, 2023

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Oct 6, 2023
@iancha1992
Copy link
Copy Markdown
Member

iancha1992 commented Oct 6, 2023

@bazel-io fork 6.4.0

@bazel-io bazel-io mentioned this pull request Oct 6, 2023
Closed
@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Oct 6, 2023
iancha1992 pushed a commit to iancha1992/bazel that referenced this pull request Oct 6, 2023
@thii @iancha1992
Flip --experimental_cc_implementation_deps
a6d8819 
This allows distributing libraries as source that use
`implementation_deps`.

Closes bazelbuild#19724.

PiperOrigin-RevId: 571105562
Change-Id: I268c5aa0fd83b220aa85dbeb6eef6a07f6b7d3f7
@iancha1992 iancha1992 mentioned this pull request Oct 6, 2023
Merged
iancha1992 added a commit that referenced this pull request Oct 10, 2023
@iancha1992 @thii
[6.4.0] Flip --experimental_cc_implementation_deps (#19751)
924bee9 
This allows distributing libraries as source that use
`implementation_deps`.

Closes #19724.

Commit
05787f3

PiperOrigin-RevId: 571105562
Change-Id: I268c5aa0fd83b220aa85dbeb6eef6a07f6b7d3f7

Co-authored-by: Thi Don <t@thi.im>
tpudlik added a commit to tpudlik/bazel that referenced this pull request Oct 10, 2023
@tpudlik
Update implementation_deps documentation
e4cf3ab 
The experimental flag was flipped in bazelbuild#19724.
@tpudlik tpudlik mentioned this pull request Oct 10, 2023
Closed
@iancha1992
Copy link
Copy Markdown
Member

iancha1992 commented Oct 10, 2023

The changes in this PR have been included in Bazel 6.4.0 RC2. Please test out the release candidate and report any issues as soon as possible. If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=last_rc.
Thanks!

copybara-service bot pushed a commit that referenced this pull request Nov 28, 2023
@tpudlik @copybara-github
Update implementation_deps documentation
d35961e 
The experimental flag was flipped in #19724.

Closes #19789.

PiperOrigin-RevId: 586034854
Change-Id: Ia157da597a27c13789e7803655bf82e1138dddfc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@comius comius Awaiting requested review from comius

@buildbreaker2021 buildbreaker2021 Awaiting requested review from buildbreaker2021

Assignees

@buildbreaker2021 buildbreaker2021

Labels

team-Rules-CPP Issues for C++ rules

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thii @iancha1992 @bazel-io @buildbreaker2021