Merge rule and aspect validation output groups#19630
Closed
fmeum wants to merge 1 commit intobazelbuild:masterfrom
Closed
Merge rule and aspect validation output groups#19630fmeum wants to merge 1 commit intobazelbuild:masterfrom
fmeum wants to merge 1 commit intobazelbuild:masterfrom
Conversation
By merging the special `_validation` output groups across a rule and its attached aspects, aspects and rules can simultaneously use validation actions.
e7d115e to
caef2f8
Compare
|
Awesome, thanks for jumping on this so quickly! |
Member
|
cc @comius |
|
cc @lberki |
Contributor
lberki
approved these changes
Oct 5, 2023
Collaborator
Author
|
@bazel-io flag |
Member
|
@bazel-io fork 6.4.0 |
Member
|
@fmeum @ahumesky @lberki @ismell There were some conflicts when cherry-picking this to release-6.4.0.
is in release-6.4.0 branch. But expected below before the cherry-pick Also, cc: @bazelbuild/triage |
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Oct 6, 2023
By merging the special `_validation` output groups across a rule and its attached aspects, aspects and rules can simultaneously use validation actions. Fixes bazelbuild#19624 Closes bazelbuild#19630. PiperOrigin-RevId: 571084964 Change-Id: I3135ce1f9e61124e96a3b7d8e0ea0c3a3cdf526d Fixes bazelbuild#19742
Collaborator
Author
|
@iancha1992 I performed a manual cherry-pick in #19745. |
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By merging the special
_validationoutput groups across a rule and its attached aspects, aspects and rules can simultaneously use validation actions.Fixes #19624