Skip to content

Show test labels in summaries in display form#19593

Closed
fmeum wants to merge 1 commit intobazelbuild:masterfrom
fmeum:display-form-test-summaries
Closed

Show test labels in summaries in display form#19593
fmeum wants to merge 1 commit intobazelbuild:masterfrom
fmeum:display-form-test-summaries

Conversation

@fmeum
Copy link
Copy Markdown
Collaborator

@fmeum fmeum commented Sep 22, 2023

When running external tests with Bzlmod, this results in apparent labels instead of canonical ones.

@fmeum
Show test labels in summaries in display form
e22d22a 
When running external tests with Bzlmod, this results in apparent
labels instead of canonical ones.
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Sep 22, 2023
@fmeum fmeum marked this pull request as draft September 22, 2023 11:39
@fmeum fmeum marked this pull request as ready for review September 22, 2023 12:07
@sgowroji sgowroji added the team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. label Sep 22, 2023
@Wyverald Wyverald added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Sep 22, 2023
@fmeum
Copy link
Copy Markdown
Collaborator Author

fmeum commented Sep 22, 2023

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Sep 22, 2023
@iancha1992
Copy link
Copy Markdown
Member

iancha1992 commented Sep 22, 2023

@bazel-io fork 6.4.0

@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Sep 22, 2023
@bazel-io bazel-io mentioned this pull request Sep 22, 2023
Closed
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Sep 25, 2023
@bazel-io bazel-io mentioned this pull request Sep 25, 2023
Merged
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Sep 25, 2023
@fmeum @bazel-io
Show test labels in summaries in display form
196f62e 
When running external tests with Bzlmod, this results in apparent labels instead of canonical ones.

Closes bazelbuild#19593.

PiperOrigin-RevId: 568312090
Change-Id: Ice4c48d9ae7e313b33ad41fe954ce57d5a1e2b12
@fmeum fmeum deleted the display-form-test-summaries branch September 26, 2023 09:24
iancha1992 pushed a commit that referenced this pull request Sep 26, 2023
@bazel-io @fmeum
[6.4.0] Show test labels in summaries in display form (#19625)
8d04038 
When running external tests with Bzlmod, this results in apparent labels
instead of canonical ones.

Closes #19593.

Commit
4c15434

PiperOrigin-RevId: 568312090
Change-Id: Ice4c48d9ae7e313b33ad41fe954ce57d5a1e2b12

Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
@iancha1992
Copy link
Copy Markdown
Member

iancha1992 commented Oct 10, 2023

The changes in this PR have been included in Bazel 6.4.0 RC2. Please test out the release candidate and report any issues as soon as possible. If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=last_rc.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Wyverald Wyverald Wyverald approved these changes

@meteorcloudy meteorcloudy Awaiting requested review from meteorcloudy

Assignees

No one assigned

Labels

team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fmeum @iancha1992 @Wyverald @bazel-io @sgowroji