Error on potential unsupported /showIncludes lines#19580
Closed
fmeum wants to merge 1 commit intobazelbuild:masterfrom
Closed
Error on potential unsupported /showIncludes lines#19580fmeum wants to merge 1 commit intobazelbuild:masterfrom
/showIncludes lines#19580fmeum wants to merge 1 commit intobazelbuild:masterfrom
Conversation
e1ae2d4 to
b00f9c6
Compare
/showIncludes lines/showIncludes lines
b00f9c6 to
c47c9a8
Compare
Collaborator
Author
|
@bazel-io flag |
Collaborator
Author
|
@meteorcloudy I tested this manually by uninstalling my English language pack and then doing a build without prior clean with just a French language pack. |
src/main/java/com/google/devtools/build/lib/rules/cpp/ShowIncludesFilter.java
Outdated
Show resolved
Hide resolved
Member
|
@bazel-io fork 6.4.0 |
This error ensures that removing the English language pack for MSVC without also refetching `@local_config_cc` doesn't result in silently incorrect incremental builds. I considered making this a warning instead, but that would either result in warning spam (if a false positive) or drown in the unfiltered MSVC output (if a true positive). Making this an error is better for correctness and will lead users to report any false positive matches.
c47c9a8 to
50b5b03
Compare
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Sep 25, 2023
This error ensures that removing the English language pack for MSVC without also refetching `@local_config_cc` doesn't result in silently incorrect incremental builds. I considered making this a warning instead, but that would either result in warning spam (if a false positive) or drown in the unfiltered MSVC output (if a true positive). Making this an error is better for correctness and will lead users to report any false positive matches. Fixes bazelbuild#19439 (comment) Closes bazelbuild#19580. PiperOrigin-RevId: 568133958 Change-Id: If43924da6ba2f332edf4db0aed24056aa89fbb75
meteorcloudy
pushed a commit
that referenced
this pull request
Sep 25, 2023
This error ensures that removing the English language pack for MSVC without also refetching `@local_config_cc` doesn't result in silently incorrect incremental builds. I considered making this a warning instead, but that would either result in warning spam (if a false positive) or drown in the unfiltered MSVC output (if a true positive). Making this an error is better for correctness and will lead users to report any false positive matches. Fixes #19439 (comment) Closes #19580. Commit a0497a0 PiperOrigin-RevId: 568133958 Change-Id: If43924da6ba2f332edf4db0aed24056aa89fbb75 Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
Member
|
The changes in this PR have been included in Bazel 6.4.0 RC2. Please test out the release candidate and report any issues as soon as possible. If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=last_rc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This error ensures that removing the English language pack for MSVC
without also refetching
@local_config_ccdoesn't result in silentlyincorrect incremental builds.
I considered making this a warning instead, but that would either result
in warning spam (if a false positive) or drown in the unfiltered MSVC
output (if a true positive). Making this an error is better for
correctness and will lead users to report any false positive matches.
Fixes #19439 (comment)