Skip to content

Print dep chain leading to a module that is in error#19535

Closed
fmeum wants to merge 1 commit intobazelbuild:masterfrom
fmeum:dep-chain
Closed

Print dep chain leading to a module that is in error#19535
fmeum wants to merge 1 commit intobazelbuild:masterfrom
fmeum:dep-chain

Conversation

@fmeum
Copy link
Copy Markdown
Collaborator

@fmeum fmeum commented Sep 15, 2023

When a module file has an error, this now results in an error such as:

ERROR: Error computing the main repository mapping: in module dependency chain <root> -> grpc@1.48.1.bcr.1 -> re2@2021-09-01: the MODULE.bazel file of re2@2021-09-01 declares a different version (2021-09-02)

@github-actions github-actions bot added awaiting-review PR is awaiting review from an assigned reviewer team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. labels Sep 15, 2023
Copy link
Copy Markdown
Member

@Wyverald Wyverald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great!

When a module file has an error, this now results in an error such as:
```
ERROR: Error computing the main repository mapping: in module dependency <root> -> grpc@1.48.1.bcr.1 -> re2@2021-09-01: the MODULE.bazel file of re2@2021-09-01 declares a different version (2021-09-02)
```
@fmeum
Copy link
Copy Markdown
Collaborator Author

fmeum commented Sep 15, 2023

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Sep 15, 2023
@Wyverald Wyverald added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Sep 15, 2023
@Wyverald
Copy link
Copy Markdown
Member

@bazel-io fork 6.4.0

@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Sep 15, 2023
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Sep 15, 2023
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Sep 15, 2023
When a module file has an error, this now results in an error such as:

```
ERROR: Error computing the main repository mapping: in module dependency chain <root> -> grpc@1.48.1.bcr.1 -> re2@2021-09-01: the MODULE.bazel file of re2@2021-09-01 declares a different version (2021-09-02)
```

Closes bazelbuild#19535.

PiperOrigin-RevId: 565759770
Change-Id: I8ec788de4e83f59cc5ff5dc6f9fac19322181c08
Wyverald pushed a commit that referenced this pull request Sep 15, 2023
When a module file has an error, this now results in an error such as:

```
ERROR: Error computing the main repository mapping: in module dependency chain <root> -> grpc@1.48.1.bcr.1 -> re2@2021-09-01: the MODULE.bazel file of re2@2021-09-01 declares a different version (2021-09-02)
```

Closes #19535.

Commit
184796d

PiperOrigin-RevId: 565759770
Change-Id: I8ec788de4e83f59cc5ff5dc6f9fac19322181c08

Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
@fmeum fmeum deleted the dep-chain branch September 16, 2023 06:11
@iancha1992
Copy link
Copy Markdown
Member

The changes in this PR have been included in Bazel 6.4.0 RC1. Please test out the release candidate and report any issues as soon as possible. If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=last_rc.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants