Only use /showIncludes if supported#19497
Closed
fmeum wants to merge 1 commit intobazelbuild:masterfrom
Closed
Conversation
Collaborator
Author
|
CC @kkpattern @konste Could you test this? |
Contributor
|
Sure, I'll test this branch later. |
Collaborator
Author
|
@bazel-io flag |
Member
|
@bazel-io fork 6.4.0 |
This was referenced Sep 14, 2023
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Sep 14, 2023
The auto-configured Windows toolchain now only enables `/showIncludes` if the English language pack for VS is installed and the compiler language can thus be forced to be English. Other languages may use encodings other than ASCII or UTF-8 and thus fail to be recognized by Bazel's `ShowInputFilter`. A warning with a suggested fix is shown if this fails. See bazelbuild#19451 Fixes bazelbuild#19439 RELNOTES: Compilation actions using the auto-configured MSVC toolchain are forced to emit error messages in English if the English language pack for Visual Studio is installed. Closes bazelbuild#19497. PiperOrigin-RevId: 565251294 Change-Id: I926c484c21310ee4d7b5e8d5756cb61e45d6e6ac
meteorcloudy
pushed a commit
that referenced
this pull request
Sep 14, 2023
The auto-configured Windows toolchain now only enables `/showIncludes` if the English language pack for VS is installed and the compiler language can thus be forced to be English. Other languages may use encodings other than ASCII or UTF-8 and thus fail to be recognized by Bazel's `ShowInputFilter`. A warning with a suggested fix is shown if this fails. See #19451 Fixes #19439 RELNOTES: Compilation actions using the auto-configured MSVC toolchain are forced to emit error messages in English if the English language pack for Visual Studio is installed. Closes #19497. Commit 0f10359 PiperOrigin-RevId: 565251294 Change-Id: I926c484c21310ee4d7b5e8d5756cb61e45d6e6ac Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The auto-configured Windows toolchain now only enables
/showIncludesif the English language pack for VS is installed and the compiler language can thus be forced to be English. Other languages may use encodings other than ASCII or UTF-8 and thus fail to be recognized by Bazel'sShowInputFilter. A warning with a suggested fix is shown if this fails.See #19451
Fixes #19439
RELNOTES: Compilation actions using the auto-configured MSVC toolchain are forced to emit error messages in English if the English language pack for Visual Studio is installed.