Check if json.gz files exist, not the gcov version.#18878
Closed
c-mita wants to merge 1 commit intobazelbuild:masterfrom
Closed
Check if json.gz files exist, not the gcov version.#18878c-mita wants to merge 1 commit intobazelbuild:masterfrom
c-mita wants to merge 1 commit intobazelbuild:masterfrom
Conversation
Different versions of gcov output different types of files; older versions output textual data, newer ones output compressed JSON files (the switch happens in gcov). "llvm-cov gcov" is supposed to be compatible with gcov, but never outputs compressed JSON files. This means the version check will break if gcov is substituted with this tool. Checking for the output files created should avoid this issue, and be a more robust check overall. Fixes bazelbuild#18874
Collaborator
|
@bazel-io flag |
Member
|
@bazel-io fork 6.3.0 |
iancha1992
pushed a commit
to iancha1992/bazel
that referenced
this pull request
Jul 10, 2023
Different versions of gcov output different types of files; older versions output textual data, newer ones output compressed JSON files (the switch happens in gcov). "llvm-cov gcov" is supposed to be compatible with gcov, but never outputs compressed JSON files. This means the version check will break if gcov is substituted with this tool. Checking for the output files created should avoid this issue, and be a more robust check overall. Fixes bazelbuild#18874 Closes bazelbuild#18878. PiperOrigin-RevId: 546901422 Change-Id: Ibcff1310de06bc8bd4637ad8a22f719d7608ea20
iancha1992
added a commit
that referenced
this pull request
Jul 11, 2023
Different versions of gcov output different types of files; older versions output textual data, newer ones output compressed JSON files (the switch happens in gcov). "llvm-cov gcov" is supposed to be compatible with gcov, but never outputs compressed JSON files. This means the version check will break if gcov is substituted with this tool. Checking for the output files created should avoid this issue, and be a more robust check overall. Fixes #18874 Closes #18878. PiperOrigin-RevId: 546901422 Change-Id: Ibcff1310de06bc8bd4637ad8a22f719d7608ea20 Co-authored-by: Charles Mita <cmita@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Different versions of gcov output different types of files; older versions output textual data, newer ones output compressed JSON files (the switch happens in gcov).
"llvm-cov gcov" is supposed to be compatible with gcov, but never outputs compressed JSON files. This means the version check will break if gcov is substituted with this tool.
Checking for the output files created should avoid this issue, and be a more robust check overall.
Fixes #18874