Report dev/non-dev deps imported via non-dev/dev usages#18832
Closed
fmeum wants to merge 1 commit intobazelbuild:masterfrom
Closed
Report dev/non-dev deps imported via non-dev/dev usages#18832fmeum wants to merge 1 commit intobazelbuild:masterfrom
fmeum wants to merge 1 commit intobazelbuild:masterfrom
Conversation
If a repository generated by a module extension corresponds to a dev tag but is imported on non-dev usage (or vice versa), the build can fail if the module is used by other modules. `ModuleExtensionMetadata` already generated fixup commands for this case, but now also explains the situation and impact.
Collaborator
Author
|
@bazel-io flag |
Member
|
@bazel-io fork 6.3.0 |
Wyverald
approved these changes
Jul 12, 2023
iancha1992
pushed a commit
to iancha1992/bazel
that referenced
this pull request
Jul 12, 2023
If a repository generated by a module extension corresponds to a dev tag but is imported on a non-dev usage proxy (or vice versa), the build can fail if the module is used by other modules. `ModuleExtensionMetadata` already generated fixup commands for this case, but now also explains the situation and impact. Closes bazelbuild#18832. PiperOrigin-RevId: 547589845 Change-Id: I58a63b1aa6b60849a350202097515c7840540800
iancha1992
added a commit
that referenced
this pull request
Jul 12, 2023
If a repository generated by a module extension corresponds to a dev tag but is imported on a non-dev usage proxy (or vice versa), the build can fail if the module is used by other modules. `ModuleExtensionMetadata` already generated fixup commands for this case, but now also explains the situation and impact. Closes #18832. PiperOrigin-RevId: 547589845 Change-Id: I58a63b1aa6b60849a350202097515c7840540800 Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a repository generated by a module extension corresponds to a dev tag but is imported on a non-dev usage proxy (or vice versa), the build can fail if the module is used by other modules.
ModuleExtensionMetadataalready generated fixup commands for this case, but now also explains the situation and impact.