Fail on isolated extension usages without imports#18761
Closed
fmeum wants to merge 2 commits intobazelbuild:masterfrom
Closed
Fail on isolated extension usages without imports#18761fmeum wants to merge 2 commits intobazelbuild:masterfrom
fmeum wants to merge 2 commits intobazelbuild:masterfrom
Conversation
Such usages have no effect and are never evaluated. Since this may not be obvious and `use_repo` fixup messages are only emitted when the extension is evaluated, fail with an error message instructing users to add a `use_repo`.
Wyverald
approved these changes
Jun 23, 2023
Collaborator
Author
|
@bazel-io flag |
Member
|
@bazel-io fork 6.3.0 |
iancha1992
pushed a commit
to iancha1992/bazel
that referenced
this pull request
Jun 27, 2023
Such usages have no effect and are never evaluated. Since this may not be obvious and `use_repo` fixup messages are only emitted when the extension is evaluated, fail with an error message instructing users to add a `use_repo`. Closes bazelbuild#18761. PiperOrigin-RevId: 543496257 Change-Id: Ia4b4ece2c15e9e5a139d2a97dcc7baba1b128a70
iancha1992
added a commit
that referenced
this pull request
Jun 27, 2023
Such usages have no effect and are never evaluated. Since this may not be obvious and `use_repo` fixup messages are only emitted when the extension is evaluated, fail with an error message instructing users to add a `use_repo`. Closes #18761. PiperOrigin-RevId: 543496257 Change-Id: Ia4b4ece2c15e9e5a139d2a97dcc7baba1b128a70 Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Such usages have no effect and are never evaluated. Since this may not be obvious and
use_repofixup messages are only emitted when the extension is evaluated, fail with an error message instructing users to add ause_repo.