Allow module extension usages to be isolated#18529
Closed
fmeum wants to merge 5 commits intobazelbuild:masterfrom
Closed
Allow module extension usages to be isolated#18529fmeum wants to merge 5 commits intobazelbuild:masterfrom
fmeum wants to merge 5 commits intobazelbuild:masterfrom
Conversation
4d34d12 to
c816feb
Compare
Wyverald
reviewed
Jun 2, 2023
src/main/java/com/google/devtools/build/lib/bazel/bzlmod/BazelDepGraphFunction.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/bazel/bzlmod/ModuleExtensionId.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/bazel/bzlmod/ModuleFileGlobals.java
Show resolved
Hide resolved
aherrmann
reviewed
Jun 8, 2023
Contributor
aherrmann
left a comment
There was a problem hiding this comment.
I like this idea. I think this would help with the distinction between globally unified and local packages in rules_nixpkgs, see here. The globally unified ones would be provided by a regular extension, and the local ones by an isolated extension.
src/main/java/com/google/devtools/build/lib/bazel/bzlmod/ModuleFileGlobals.java
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/bazel/bzlmod/ModuleFileGlobals.java
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
I added tests as well as @Wyverald bazelbuild/buildtools#1171 is the corresponding change to buildozer. |
Collaborator
Author
|
Gson doesn't seem to handle Edit: I found a way, but it's rather verbose. |
c83e00e to
23291be
Compare
Member
Unfortunately not. Probably writing an adapter for it, though you will still need to handle the object type somehow Ex: via TypeToken or something. |
Collaborator
Author
|
I ended up writing my own |
Wyverald
approved these changes
Jun 14, 2023
src/main/java/com/google/devtools/build/lib/bazel/bzlmod/ModuleFileGlobals.java
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/bazel/bzlmod/ModuleFileGlobals.java
Outdated
Show resolved
Hide resolved
src/test/java/com/google/devtools/build/lib/bazel/bzlmod/ModuleExtensionResolutionTest.java
Outdated
Show resolved
Hide resolved
If `isolated = True` is specified on `use_extension`, that particular usage will be isolated from all other usages, both in the same and other modules. Module extensions can check whether they are isolated (e.g. in case they can only be used in this way) via `module_ctx.is_isolated`.
Collaborator
Author
|
Just in case you missed it: I changed the name of the parameter from |
Wyverald
approved these changes
Jun 15, 2023
Collaborator
Author
|
@bazel-io flag |
Member
|
@bazel-io fork 6.3.0 |
iancha1992
pushed a commit
to iancha1992/bazel
that referenced
this pull request
Jun 20, 2023
If `isolate = True` is specified on `use_extension`, that particular usage will be isolated from all other usages, both in the same and other modules. Module extensions can check whether they are isolated (e.g. in case they can only be used in this way) via `module_ctx.is_isolated`. Closes bazelbuild#18529. PiperOrigin-RevId: 541823020 Change-Id: I68a7b49914bbc1fd50df2fda7a0af1e47421bb92
iancha1992
added a commit
that referenced
this pull request
Jun 21, 2023
If `isolate = True` is specified on `use_extension`, that particular usage will be isolated from all other usages, both in the same and other modules. Module extensions can check whether they are isolated (e.g. in case they can only be used in this way) via `module_ctx.is_isolated`. Closes #18529. PiperOrigin-RevId: 541823020 Change-Id: I68a7b49914bbc1fd50df2fda7a0af1e47421bb92 Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
aherrmann
added a commit
to tweag/rules_nixpkgs
that referenced
this pull request
Sep 29, 2023
This uses the new isolated module extensions feature [1], instead of a hub-repository approach [2] [3], to distinguish globally unified repositories and locally specialized repositories. [1]: bazelbuild/bazel#18529 [2]: bazelbuild/bazel#17048 [3]: bazelbuild/bazel#17493
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
isolate = Trueis specified onuse_extension, that particular usage will be isolated from all other usages, both in the same and other modules.Module extensions can check whether they are isolated (e.g. in case they can only be used in this way) via
module_ctx.is_isolated.