Skip to content

Teach ijar about dynamic constants.#18406

Closed
benjaminp wants to merge 1 commit intobazelbuild:masterfrom
benjaminp:benjamin-ijar-dynamic-constant
Closed

Teach ijar about dynamic constants.#18406
benjaminp wants to merge 1 commit intobazelbuild:masterfrom
benjaminp:benjamin-ijar-dynamic-constant

Conversation

@benjaminp
Copy link
Copy Markdown
Collaborator

@benjaminp benjaminp commented May 15, 2023

@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label May 15, 2023
@benjaminp benjaminp force-pushed the benjamin-ijar-dynamic-constant branch from 425a5d5 to 0f0abbd Compare May 15, 2023 20:15
@benjaminp benjaminp requested a review from a team as a code owner May 15, 2023 20:15
@benjaminp benjaminp requested review from gregestren and removed request for a team May 15, 2023 20:15
@benjaminp benjaminp force-pushed the benjamin-ijar-dynamic-constant branch from 0f0abbd to 634562d Compare May 15, 2023 20:15
@sgowroji sgowroji added team-Configurability platforms, toolchains, cquery, select(), config transitions team-Rules-Java Issues for Java rules and removed team-Configurability platforms, toolchains, cquery, select(), config transitions labels May 16, 2023
@gregestren gregestren removed their request for review June 1, 2023 23:47
@fmeum
Copy link
Copy Markdown
Collaborator

fmeum commented Jun 14, 2023

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Jun 14, 2023
@cushon cushon mentioned this pull request Jun 14, 2023
Closed
@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jun 14, 2023
@iancha1992
Copy link
Copy Markdown
Member

iancha1992 commented Jun 14, 2023

@bazel-io fork 6.3.0

@bazel-io bazel-io mentioned this pull request Jun 14, 2023
Closed
@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Jun 14, 2023
copybara-service bot pushed a commit that referenced this pull request Jun 14, 2023
@benjaminp @iancha1992
Teach ijar about dynamic constants.
37c80e8 
#18360

Partial commit for third_party/*, see #18406.

Signed-off-by: Hee Cha <heec@google.com>
@iancha1992
Copy link
Copy Markdown
Member

iancha1992 commented Jun 14, 2023

Third party changes merged at: 37c80e8

@iancha1992 iancha1992 closed this Jun 14, 2023
@iancha1992 iancha1992 removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Jun 14, 2023
iancha1992 pushed a commit to iancha1992/bazel that referenced this pull request Jun 14, 2023
@benjaminp @iancha1992
Teach ijar about dynamic constants.
dd0db68 
bazelbuild#18360

Partial commit for third_party/*, see bazelbuild#18406.

Signed-off-by: Hee Cha <heec@google.com>
@iancha1992 iancha1992 mentioned this pull request Jun 14, 2023
Closed
@benjaminp
Copy link
Copy Markdown
Collaborator Author

benjaminp commented Jun 14, 2023

@iancha1992 Thank you for merging. However, there's some kind of extra-special procedure for importing ijar changes. It doesn't seem that was followed in this case, causing the changes to be reverted by the next change (651c451).

@benjaminp benjaminp deleted the benjamin-ijar-dynamic-constant branch June 14, 2023 20:09
@meteorcloudy
Copy link
Copy Markdown
Member

meteorcloudy commented Jun 15, 2023

@cushon Can you help importing this PR again?

@cushon
Copy link
Copy Markdown
Contributor

cushon commented Jun 15, 2023

Sure, I'm on it: cl/540578976

copybara-service bot pushed a commit that referenced this pull request Jun 16, 2023
@benjaminp @copybara-github
BEGIN_PUBLIC
69d2991 
PR #18406: Teach ijar about dynamic constants.

Imported from GitHub PR #18406

END_PUBLIC

PiperOrigin-RevId: 540750474
Change-Id: If61bcaaf018b92a1bf87335c1075c28294932b1f
@cushon
Copy link
Copy Markdown
Contributor

cushon commented Jun 16, 2023

The change has been imported! 69d2991

iancha1992 pushed a commit to iancha1992/bazel that referenced this pull request Jun 16, 2023
@benjaminp @iancha1992
BEGIN_PUBLIC
88dcfee 
PR bazelbuild#18406: Teach ijar about dynamic constants.

Imported from GitHub PR bazelbuild#18406

END_PUBLIC

PiperOrigin-RevId: 540750474
Change-Id: If61bcaaf018b92a1bf87335c1075c28294932b1f
@iancha1992 iancha1992 mentioned this pull request Jun 16, 2023
Closed
iancha1992 pushed a commit to iancha1992/bazel that referenced this pull request Jun 20, 2023
@benjaminp @iancha1992
BEGIN_PUBLIC
9c12bea 
PR bazelbuild#18406: Teach ijar about dynamic constants.

Imported from GitHub PR bazelbuild#18406

END_PUBLIC

PiperOrigin-RevId: 540750474
Change-Id: If61bcaaf018b92a1bf87335c1075c28294932b1f
@iancha1992 iancha1992 mentioned this pull request Jun 20, 2023
Merged
iancha1992 added a commit that referenced this pull request Jun 22, 2023
@iancha1992 @benjaminp
BEGIN_PUBLIC (#18729)
b752c2f 
PR #18406: Teach ijar about dynamic constants.

Imported from GitHub PR #18406

END_PUBLIC

PiperOrigin-RevId: 540750474
Change-Id: If61bcaaf018b92a1bf87335c1075c28294932b1f

Co-authored-by: Benjamin Peterson <benjamin@engflow.com>
traversaro pushed a commit to traversaro/bazel that referenced this pull request Jun 24, 2023
@benjaminp @traversaro
Teach ijar about dynamic constants.
9a14304 
bazelbuild#18360

Partial commit for third_party/*, see bazelbuild#18406.

Signed-off-by: Hee Cha <heec@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cushon cushon cushon approved these changes

Assignees

No one assigned

Labels

team-Rules-Java Issues for Java rules

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@benjaminp @fmeum @iancha1992 @meteorcloudy @cushon @bazel-io @sgowroji