Skip to content

Pass version to java_runtimes created by local_java_repository#18344

Closed
fmeum wants to merge 1 commit intobazelbuild:masterfrom
fmeum:17281-implicit-version
Closed

Pass version to java_runtimes created by local_java_repository#18344
fmeum wants to merge 1 commit intobazelbuild:masterfrom
fmeum:17281-implicit-version

Conversation

@fmeum
Copy link
Copy Markdown
Collaborator

@fmeum fmeum commented May 8, 2023 •
edited
Loading

Work towards #17281

@fmeum fmeum requested review from benjaminp and hvadehra May 8, 2023 10:17
@fmeum fmeum marked this pull request as ready for review May 8, 2023 10:17
@github-actions github-actions bot added awaiting-review PR is awaiting review from an assigned reviewer team-Rules-Java Issues for Java rules labels May 8, 2023
@hvadehra hvadehra added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels May 9, 2023
@copybara-service copybara-service bot closed this in 1c1584b May 9, 2023
@fmeum fmeum deleted the 17281-implicit-version branch May 9, 2023 19:15
@Pavank1992 Pavank1992 removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label May 10, 2023
@fmeum
Copy link
Copy Markdown
Collaborator Author

fmeum commented May 10, 2023

@hvadehra @comius This commit as well as the one that introduced the version attribute of java_runtime need to be synced to rules_java so that they are picked up with Bzlmod (and in Bazel CI). This may require using bazel_features in rules_java to detect whether this attribute is available.

@fmeum
Copy link
Copy Markdown
Collaborator Author

fmeum commented May 10, 2023

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label May 10, 2023
@keertk
Copy link
Copy Markdown
Member

keertk commented May 10, 2023

@bazel-io fork 6.3.0

@bazel-io bazel-io mentioned this pull request May 10, 2023
Closed
@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label May 10, 2023
@iancha1992 iancha1992 mentioned this pull request May 15, 2023
Closed
iancha1992 pushed a commit to iancha1992/bazel that referenced this pull request May 15, 2023
@fmeum @iancha1992
Pass version to java_runtimes created by local_java_repository
d9d7be5 
Work towards bazelbuild#17281

Closes bazelbuild#18344.

PiperOrigin-RevId: 530662071
Change-Id: I9376cbc7117d9c8370cf50d42988cca44dad9785
@iancha1992 iancha1992 mentioned this pull request May 15, 2023
Merged
iancha1992 added a commit that referenced this pull request May 17, 2023
@iancha1992 @fmeum @keertk
Pass version to java_runtimes created by local_java_repository (#18415)
5756652 
Work towards #17281

Closes #18344.

PiperOrigin-RevId: 530662071
Change-Id: I9376cbc7117d9c8370cf50d42988cca44dad9785

Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
Co-authored-by: keertk <keerthanakumar@google.com>
fweikert pushed a commit to fweikert/bazel that referenced this pull request May 25, 2023
@fmeum @fweikert
Pass version to java_runtimes created by local_java_repository
821d9d0 
Work towards bazelbuild#17281

Closes bazelbuild#18344.

PiperOrigin-RevId: 530662071
Change-Id: I9376cbc7117d9c8370cf50d42988cca44dad9785
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hvadehra hvadehra hvadehra approved these changes

@benjaminp benjaminp Awaiting requested review from benjaminp

Assignees

No one assigned

Labels

team-Rules-Java Issues for Java rules

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fmeum @keertk @hvadehra @bazel-io @Pavank1992