Skip to content

Update java_tools v11.12#17642

Closed
ShreeM01 wants to merge 4 commits intomasterfrom
kshyanashree-patch-5
Closed

Update java_tools v11.12#17642
ShreeM01 wants to merge 4 commits intomasterfrom
kshyanashree-patch-5

Conversation

@ShreeM01
Copy link
Copy Markdown
Contributor

@ShreeM01 ShreeM01 commented Mar 1, 2023

Release tracking issue: bazelbuild/java_tools#64

@ShreeM01 ShreeM01 requested review from comius and hvadehra March 1, 2023 23:59
@ShreeM01 ShreeM01 added team-Rules-Java Issues for Java rules awaiting-review PR is awaiting review from an assigned reviewer labels Mar 2, 2023
@keertk keertk added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Mar 3, 2023
@copybara-service copybara-service bot closed this in 8d476cf Mar 3, 2023
@sgowroji sgowroji removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Mar 3, 2023
@comius
Copy link
Copy Markdown
Contributor

comius commented Mar 3, 2023

Hey @kshyanashree, could you also update versions in java_tools here: https://github.com/bazelbuild/rules_java/blob/master/java/repositories.bzl#L22-L61

and could you update java_tools release instructions with this?

Example PR: bazelbuild/rules_java#87
It's possible to update it also internally if that's faster for you (cl/511449956).

@ShreeM01
Copy link
Copy Markdown
Contributor Author

ShreeM01 commented Mar 3, 2023

Hey @kshyanashree, could you also update versions in java_tools here: https://github.com/bazelbuild/rules_java/blob/master/java/repositories.bzl#L22-L61

and could you update java_tools release instructions with this?

Example PR: bazelbuild/rules_java#87 It's possible to update it also internally if that's faster for you (cl/511449956).

Sure @comius!

@ShreeM01 ShreeM01 reopened this Mar 3, 2023
@keertk keertk closed this Mar 3, 2023
@fmeum
Copy link
Copy Markdown
Collaborator

fmeum commented Mar 7, 2023

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Mar 7, 2023
@ShreeM01
Copy link
Copy Markdown
Contributor Author

ShreeM01 commented Mar 7, 2023

@bazel-io fork 6.2.0

@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Mar 7, 2023
ShreeM01 added a commit to ShreeM01/bazel that referenced this pull request Mar 10, 2023
Release tracking issue: bazelbuild/java_tools#64

Closes bazelbuild#17642.

PiperOrigin-RevId: 513763909
Change-Id: I197d05c9b72a79bdcb62716027ee5d87335fba88
ShreeM01 added a commit that referenced this pull request Mar 13, 2023
* Update java_tools v11.12

Release tracking issue: bazelbuild/java_tools#64

Closes #17642.

PiperOrigin-RevId: 513763909
Change-Id: I197d05c9b72a79bdcb62716027ee5d87335fba88

* Make EmptyTopLevelDeclaration a warning

PiperOrigin-RevId: 501864491
Change-Id: I06db1964964a2a817f6255153d7ee0121397720d

---------

Co-authored-by: kshyanashree <109167932+kshyanashree@users.noreply.github.com>
Co-authored-by: Googler <cushon@google.com>
fweikert pushed a commit to fweikert/bazel that referenced this pull request May 25, 2023
Release tracking issue: bazelbuild/java_tools#64

Closes bazelbuild#17642.

PiperOrigin-RevId: 513763909
Change-Id: I197d05c9b72a79bdcb62716027ee5d87335fba88
@Wyverald Wyverald deleted the kshyanashree-patch-5 branch March 14, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-Rules-Java Issues for Java rules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants