Add .wasm cc dynamic library extension#17374
Closed
zaucy wants to merge 1 commit intobazelbuild:masterfrom
Closed
Conversation
Contributor
Author
|
@kshyanashree was the I'm happy to answer any questions if there is one. |
Contributor
Hi @zaucy! I could see some presubmits are failing, so I added label 'awaiting-user-response', Could you please fix the build failures? |
Contributor
Author
|
Ah thanks for the clarification on the user response. I did check the presubmit initially, but the error seems unrelated to my change. From log at https://buildkite.com/bazel/bazel-bazel-github-presubmit/builds/14124#01860bd4-71a2-4a5e-8c28-09abd19b4239
I can rebase to get any changes from the last 14 hours and try again. |
01b7135 to
d682ba4
Compare
oquenchil
approved these changes
Feb 3, 2023
Contributor
oquenchil
left a comment
There was a problem hiding this comment.
The change is fine. The presubmit is failing for unrelated reasons, so merging will be blocked till that is fixed.
zaucy
added a commit
to zaucy/bazel
that referenced
this pull request
Feb 8, 2023
Similar to bazelbuild#16091 except also allow the `.wasm` extension for dynamic libraries. Closes bazelbuild#17374. PiperOrigin-RevId: 507668339 Change-Id: Id85f98bb804e573e5f93a922b67baf75a22baf16
keertk
pushed a commit
that referenced
this pull request
Feb 28, 2023
* Add .wasm cc artifact executable extension This allows creating a custom cc_toolchain that compiles to WebAssembly that outputs a wasm file with the standard extension, without needing to have a genrule that renames the file Closes #16091. PiperOrigin-RevId: 503921110 Change-Id: I3ed9e50a945d2e415e2ab34bd99ceea481c987f0 * Add .wasm cc dynamic library extension Similar to #16091 except also allow the `.wasm` extension for dynamic libraries. Closes #17374. PiperOrigin-RevId: 507668339 Change-Id: Id85f98bb804e573e5f93a922b67baf75a22baf16 --------- Co-authored-by: Scott Bennett <scottbennett@google.com> Co-authored-by: kshyanashree <109167932+kshyanashree@users.noreply.github.com>
copybara-service bot
pushed a commit
that referenced
this pull request
Mar 13, 2023
This is an amendment to #17374 We have a C++ toolchain config that's being developed to support standalone wasm. We discovered that #17374 wasn't complete. Our example was poorly written and didn't actually create a wasm dynamic library. These changes allow us to successfully create a standalone wasm dynamic library. Sorry for the botched attempt previously. I would like to add tests, but I'm unsure how to approach such a tests considering the automatic toolchain doesn't support wasm AFAICT. Closes #17698. PiperOrigin-RevId: 516204125 Change-Id: Iced5cc80a3151ffde7116b6264c89eaf40466ff5
ShreeM01
pushed a commit
to ShreeM01/bazel
that referenced
this pull request
Mar 13, 2023
This is an amendment to bazelbuild#17374 We have a C++ toolchain config that's being developed to support standalone wasm. We discovered that bazelbuild#17374 wasn't complete. Our example was poorly written and didn't actually create a wasm dynamic library. These changes allow us to successfully create a standalone wasm dynamic library. Sorry for the botched attempt previously. I would like to add tests, but I'm unsure how to approach such a tests considering the automatic toolchain doesn't support wasm AFAICT. Closes bazelbuild#17698. PiperOrigin-RevId: 516204125 Change-Id: Iced5cc80a3151ffde7116b6264c89eaf40466ff5
ShreeM01
added a commit
that referenced
this pull request
Mar 13, 2023
This is an amendment to #17374 We have a C++ toolchain config that's being developed to support standalone wasm. We discovered that #17374 wasn't complete. Our example was poorly written and didn't actually create a wasm dynamic library. These changes allow us to successfully create a standalone wasm dynamic library. Sorry for the botched attempt previously. I would like to add tests, but I'm unsure how to approach such a tests considering the automatic toolchain doesn't support wasm AFAICT. Closes #17698. PiperOrigin-RevId: 516204125 Change-Id: Iced5cc80a3151ffde7116b6264c89eaf40466ff5 Co-authored-by: Ezekiel Warren <zekewarren@gmail.com>
ShreeM01
pushed a commit
to ShreeM01/bazel
that referenced
this pull request
Mar 13, 2023
This is an amendment to bazelbuild#17374 We have a C++ toolchain config that's being developed to support standalone wasm. We discovered that bazelbuild#17374 wasn't complete. Our example was poorly written and didn't actually create a wasm dynamic library. These changes allow us to successfully create a standalone wasm dynamic library. Sorry for the botched attempt previously. I would like to add tests, but I'm unsure how to approach such a tests considering the automatic toolchain doesn't support wasm AFAICT. Closes bazelbuild#17698. PiperOrigin-RevId: 516204125 Change-Id: Iced5cc80a3151ffde7116b6264c89eaf40466ff5
ShreeM01
added a commit
that referenced
this pull request
Mar 14, 2023
This is an amendment to #17374 We have a C++ toolchain config that's being developed to support standalone wasm. We discovered that #17374 wasn't complete. Our example was poorly written and didn't actually create a wasm dynamic library. These changes allow us to successfully create a standalone wasm dynamic library. Sorry for the botched attempt previously. I would like to add tests, but I'm unsure how to approach such a tests considering the automatic toolchain doesn't support wasm AFAICT. Closes #17698. PiperOrigin-RevId: 516204125 Change-Id: Iced5cc80a3151ffde7116b6264c89eaf40466ff5 Co-authored-by: Ezekiel Warren <zekewarren@gmail.com>
fweikert
pushed a commit
to fweikert/bazel
that referenced
this pull request
May 25, 2023
This is an amendment to bazelbuild#17374 We have a C++ toolchain config that's being developed to support standalone wasm. We discovered that bazelbuild#17374 wasn't complete. Our example was poorly written and didn't actually create a wasm dynamic library. These changes allow us to successfully create a standalone wasm dynamic library. Sorry for the botched attempt previously. I would like to add tests, but I'm unsure how to approach such a tests considering the automatic toolchain doesn't support wasm AFAICT. Closes bazelbuild#17698. PiperOrigin-RevId: 516204125 Change-Id: Iced5cc80a3151ffde7116b6264c89eaf40466ff5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #16091 except also allow the
.wasmextension for dynamic libraries.