Skip to content

Add -dead_strip in default opt link flags for darwin#16770

Closed
keith wants to merge 1 commit intobazelbuild:masterfrom
keith:ks/add-dead_strip-in-default-opt-link-flags-for-darwin
Closed

Add -dead_strip in default opt link flags for darwin#16770
keith wants to merge 1 commit intobazelbuild:masterfrom
keith:ks/add-dead_strip-in-default-opt-link-flags-for-darwin

Conversation

@keith
Copy link
Copy Markdown
Member

@keith keith commented Nov 15, 2022

This is similar to the --gc-sections addition here. -dead_strip is supported on all versions of ld64 we care about.

This is similar to the `--gc-sections` addition here. `-dead_strip` is
supported on all versions of ld64 we care about.
@sgowroji sgowroji added team-Rules-CPP Issues for C++ rules awaiting-review PR is awaiting review from an assigned reviewer labels Nov 15, 2022
@buildbreaker2021 buildbreaker2021 self-assigned this Jan 12, 2023
@buildbreaker2021 buildbreaker2021 self-requested a review January 12, 2023 13:47
@buildbreaker2021 buildbreaker2021 added the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Jan 12, 2023
@Wyverald Wyverald closed this in 1da8a82 Jan 12, 2023
@keith keith deleted the ks/add-dead_strip-in-default-opt-link-flags-for-darwin branch January 12, 2023 18:16
@brentleyjones
Copy link
Copy Markdown
Contributor

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Jan 12, 2023
@sgowroji sgowroji removed awaiting-review PR is awaiting review from an assigned reviewer awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally labels Jan 13, 2023
@ShreeM01
Copy link
Copy Markdown
Contributor

@bazel-io fork 6.1.0

@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Jan 17, 2023
ShreeM01 added a commit that referenced this pull request Jan 27, 2023
This is similar to the `--gc-sections` addition here. `-dead_strip` is supported on all versions of ld64 we care about.

Closes #16770.

PiperOrigin-RevId: 501557438
Change-Id: Ia5e1e94305361f10f1b20654d83edb76126b3056

Co-authored-by: Keith Smiley <keithbsmiley@gmail.com>
hvadehra pushed a commit that referenced this pull request Feb 14, 2023
This is similar to the `--gc-sections` addition here. `-dead_strip` is supported on all versions of ld64 we care about.

Closes #16770.

PiperOrigin-RevId: 501557438
Change-Id: Ia5e1e94305361f10f1b20654d83edb76126b3056
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-Rules-CPP Issues for C++ rules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants