[remote/downloader] Migrate Downloader to take Credentials#16601
Closed
Yannic wants to merge 1 commit intobazelbuild:masterfrom
Closed
[remote/downloader] Migrate Downloader to take Credentials#16601Yannic wants to merge 1 commit intobazelbuild:masterfrom
Downloader to take Credentials#16601Yannic wants to merge 1 commit intobazelbuild:masterfrom
Conversation
tjgq
requested changes
Nov 2, 2022
src/test/java/com/google/devtools/build/lib/bazel/repository/downloader/HttpDownloaderTest.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/authandtls/staticcredentials/StaticCredentials.java
Outdated
Show resolved
Hide resolved
4c861fc to
2756319
Compare
Contributor
Author
|
PTAL |
tjgq
approved these changes
Nov 2, 2022
Contributor
tjgq
left a comment
There was a problem hiding this comment.
Importing.
I think I'd prefer to put StaticCredentials.java in authandtls instead of creating another subpackage (unless you give me a strong reason not to). Thoughts?
Contributor
Author
|
SGTM |
Yannic
added a commit
to EngFlow/bazel
that referenced
this pull request
Nov 10, 2022
Progress on bazelbuild#15856 Closes bazelbuild#16601. PiperOrigin-RevId: 485837451 Change-Id: I785882d0ff3e171dcaee6aa6f628bca9232c730a
lripoche
pushed a commit
to lripoche/bazel
that referenced
this pull request
Jun 13, 2023
Progress on bazelbuild#15856 Closes bazelbuild#16601. PiperOrigin-RevId: 485837451 Change-Id: I785882d0ff3e171dcaee6aa6f628bca9232c730a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Progress on #15856