[cc] Add cc toolchain to starlark cc_proto_library#16585
Closed
Yannic wants to merge 5 commits intobazelbuild:masterfrom
Closed
[cc] Add cc toolchain to starlark cc_proto_library#16585Yannic wants to merge 5 commits intobazelbuild:masterfrom
Yannic wants to merge 5 commits intobazelbuild:masterfrom
Conversation
Contributor
Author
fmeum
reviewed
Oct 28, 2022
Collaborator
|
@buildbreaker2021 Could you review? This has the fix for the fix as well as an integration test. |
buildbreaker2021
approved these changes
Nov 2, 2022
ShreeM01
added a commit
that referenced
this pull request
Nov 4, 2022
lripoche
pushed a commit
to lripoche/bazel
that referenced
this pull request
Jun 13, 2023
Fixes bazelbuild#16577 Closes bazelbuild#16585. PiperOrigin-RevId: 485600476 Change-Id: I3c2985731ff800a2c6136f401ed3c7e5e89518ad
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16577