Fix rpath for binaries in external repositories#16008
Closed
fmeum wants to merge 2 commits intobazelbuild:masterfrom
Closed
Fix rpath for binaries in external repositories#16008fmeum wants to merge 2 commits intobazelbuild:masterfrom
fmeum wants to merge 2 commits intobazelbuild:masterfrom
Conversation
Collaborator
Author
|
@oquenchil This PR is similar to #14600, but resolves a different issue. I can rebase this PR onto #14600 if you should prefer to merge that one first. |
The solib directory is located within the subdirectory of the runfiles directory corresponding to the workspace. Thus, if a binary is contained in an external repository, its $ORIGIN relative rpath has to first ascend to the runfiles directory and then descend into the workspace directory.
5d1abde to
8dd6376
Compare
Collaborator
Author
|
@bazel-io flag |
Contributor
|
Success, this fixes test in external repositories! Thanks @fmeum ! |
Contributor
|
@bazel-io fork 5.3.0 |
1 similar comment
Contributor
|
@bazel-io fork 5.3.0 |
Collaborator
Author
|
@kshyanashree The command lacks the rc1. |
Contributor
|
@bazel-io fork 5.3.0rc1 |
Collaborator
Author
|
@kshyanashree I don't know why, but the last command failed as well. |
Member
|
Assigning to @oquenchil since this is about cc rules. |
Member
|
@bazel-io fork 5.3.0 |
Contributor
|
Hi @fmeum, Is it possible for you to get the PR review done? Since we will be merging it under the release 5.3.0. |
Collaborator
Author
|
@kshyanashree I don't know when @oquenchil will be able to review the change. It does fix a known Bazel 5 regression - is that sufficient to hold the release for it/up the priority? |
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Aug 10, 2022
The solib directory is located within the subdirectory of the runfiles directory corresponding to the workspace. Thus, if a binary is contained in an external repository, its $ORIGIN relative rpath has to first ascend to the runfiles directory and then descend into the workspace directory. Fixes bazelbuild#16003 Closes bazelbuild#16008. PiperOrigin-RevId: 466634083 Change-Id: I4ada28b459f23f68a2091dbaad9147cfec2fbe43
ShreeM01
pushed a commit
that referenced
this pull request
Aug 10, 2022
The solib directory is located within the subdirectory of the runfiles directory corresponding to the workspace. Thus, if a binary is contained in an external repository, its $ORIGIN relative rpath has to first ascend to the runfiles directory and then descend into the workspace directory. Fixes #16003 Closes #16008. PiperOrigin-RevId: 466634083 Change-Id: I4ada28b459f23f68a2091dbaad9147cfec2fbe43
Contributor
|
Although this patch fixes the remote execution case, it breaks the local execution case. In local execution, the runfiles tree contains symlinks to regular files in the output root; the $ORIGIN that the dynamic loader uses is the location of that regular file, not the symlink: and the solib directory is directly underneath This causes the test to fail: |
Collaborator
Author
|
CC @kshyanashree as a potential 5.3.0 regression. @pcjanzen Would adding both rpaths fix this problem? |
Contributor
I think so, but between this problem and #14600 there are starting to be kind of a lot of rpath entries and I can't honestly say I've thought through all the combinations. |
copybara-service bot
pushed a commit
that referenced
this pull request
Sep 12, 2022
The fix for remote execution of external dynamically linked cc_* targets in 95a5bfd regressed local execution of such targets. This is fixed by emitting two rpaths in the case of an external target. Fixes #16008 (comment) Closes #16214. PiperOrigin-RevId: 473706330 Change-Id: I500f8b1f79e4d994323651fbb5964a730f1136e3
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Sep 12, 2022
The fix for remote execution of external dynamically linked cc_* targets in 95a5bfd regressed local execution of such targets. This is fixed by emitting two rpaths in the case of an external target. Fixes bazelbuild#16008 (comment) Closes bazelbuild#16214. PiperOrigin-RevId: 473706330 Change-Id: I500f8b1f79e4d994323651fbb5964a730f1136e3
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Sep 12, 2022
The fix for remote execution of external dynamically linked cc_* targets in 95a5bfd regressed local execution of such targets. This is fixed by emitting two rpaths in the case of an external target. Fixes bazelbuild#16008 (comment) Closes bazelbuild#16214. PiperOrigin-RevId: 473706330 Change-Id: I500f8b1f79e4d994323651fbb5964a730f1136e3
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Sep 12, 2022
The fix for remote execution of external dynamically linked cc_* targets in 95a5bfd regressed local execution of such targets. This is fixed by emitting two rpaths in the case of an external target. Fixes bazelbuild#16008 (comment) Closes bazelbuild#16214. PiperOrigin-RevId: 473706330 Change-Id: I500f8b1f79e4d994323651fbb5964a730f1136e3
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Sep 12, 2022
The fix for remote execution of external dynamically linked cc_* targets in 95a5bfd regressed local execution of such targets. This is fixed by emitting two rpaths in the case of an external target. Fixes bazelbuild#16008 (comment) Closes bazelbuild#16214. PiperOrigin-RevId: 473706330 Change-Id: I500f8b1f79e4d994323651fbb5964a730f1136e3
ShreeM01
added a commit
that referenced
this pull request
Sep 12, 2022
The fix for remote execution of external dynamically linked cc_* targets in 95a5bfd regressed local execution of such targets. This is fixed by emitting two rpaths in the case of an external target. Fixes #16008 (comment) Closes #16214. PiperOrigin-RevId: 473706330 Change-Id: I500f8b1f79e4d994323651fbb5964a730f1136e3 Co-authored-by: kshyanashree <109167932+kshyanashree@users.noreply.github.com>
aiuto
pushed a commit
to aiuto/bazel
that referenced
this pull request
Oct 12, 2022
The fix for remote execution of external dynamically linked cc_* targets in 95a5bfd regressed local execution of such targets. This is fixed by emitting two rpaths in the case of an external target. Fixes bazelbuild#16008 (comment) Closes bazelbuild#16214. PiperOrigin-RevId: 473706330 Change-Id: I500f8b1f79e4d994323651fbb5964a730f1136e3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The solib directory is located within the subdirectory of the runfiles
directory corresponding to the workspace. Thus, if a binary is contained
in an external repository, its $ORIGIN relative rpath has to first
ascend to the runfiles directory and then descend into the workspace
directory.
Fixes #16003