Add worker assertions resource_processing_integration_test#15952
Closed
Bencodes wants to merge 3 commits intobazelbuild:masterfrom
Closed
Add worker assertions resource_processing_integration_test#15952Bencodes wants to merge 3 commits intobazelbuild:masterfrom
Bencodes wants to merge 3 commits intobazelbuild:masterfrom
Conversation
Contributor
Author
|
@ted-xie mind taking a look at this? |
Contributor
|
LGTM, we'll import this. |
ted-xie
approved these changes
Dec 6, 2022
Member
|
Hello @Bencodes, Could you please resolve the above conflict files. Above PR is awaiting to import. Thanks! |
e848087 to
16d47c3
Compare
Contributor
Author
|
@ted-xie I think something may have regressed here causing multiplex workers to no longer work, and these tests no longer pass against master even with all the Android related multiplex flags enabled. |
Contributor
|
@Bencodes Coincidentally, I was just looking at this yesterday and noticed the same thing. I'm working on a fix right now. |
Contributor
Author
Sounds good. Let me know when you have that fix up and i'll rebase this branch against that to confirm. |
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 27, 2023
Unblocks merging for PR #15952. RELNOTES: PiperOrigin-RevId: 505149043 Change-Id: I1cb5ccb4c162f26fea51e0cdef8c8553f3a3d5df
Contributor
|
@Bencodes I merged the fix for multiplexed workers. Could you rebase your PR branch? Once all the presubmit tests pass, we can try importing this again. |
63e0c00 to
32a1a21
Compare
Contributor
Author
|
@ted-xie rebased and updated the tests to use the correct flag. This should be ready to merge. |
ted-xie
added a commit
to ted-xie/bazel
that referenced
this pull request
Jan 27, 2023
Unblocks merging for PR bazelbuild#15952. RELNOTES: PiperOrigin-RevId: 505149043 Change-Id: I1cb5ccb4c162f26fea51e0cdef8c8553f3a3d5df
Contributor
ted-xie
added a commit
to ted-xie/bazel
that referenced
this pull request
Jan 31, 2023
Unblocks merging for PR bazelbuild#15952. RELNOTES: PiperOrigin-RevId: 505149043 Change-Id: I1cb5ccb4c162f26fea51e0cdef8c8553f3a3d5df
ted-xie
pushed a commit
to ted-xie/bazel
that referenced
this pull request
Jan 31, 2023
Adding a few assertions to the worker and multiplex worker tests to ensure that the expected workers are in fact coming up. Closes bazelbuild#15952. PiperOrigin-RevId: 505690186 Change-Id: If732c9f040ec144395b5525a48d3a7d367fe244b
ted-xie
added a commit
to ted-xie/bazel
that referenced
this pull request
Feb 7, 2023
Unblocks merging for PR bazelbuild#15952. RELNOTES: PiperOrigin-RevId: 505149043 Change-Id: I1cb5ccb4c162f26fea51e0cdef8c8553f3a3d5df
ted-xie
pushed a commit
to ted-xie/bazel
that referenced
this pull request
Feb 7, 2023
Adding a few assertions to the worker and multiplex worker tests to ensure that the expected workers are in fact coming up. Closes bazelbuild#15952. PiperOrigin-RevId: 505690186 Change-Id: If732c9f040ec144395b5525a48d3a7d367fe244b
ShreeM01
added a commit
that referenced
this pull request
Feb 7, 2023
* Fix multiplexed workers for Android busybox tools Unblocks merging for PR #15952. RELNOTES: PiperOrigin-RevId: 505149043 Change-Id: I1cb5ccb4c162f26fea51e0cdef8c8553f3a3d5df * Add worker assertions resource_processing_integration_test Adding a few assertions to the worker and multiplex worker tests to ensure that the expected workers are in fact coming up. Closes #15952. PiperOrigin-RevId: 505690186 Change-Id: If732c9f040ec144395b5525a48d3a7d367fe244b --------- Co-authored-by: Benjamin Lee <ben@ben.cm> Co-authored-by: kshyanashree <109167932+kshyanashree@users.noreply.github.com>
hvadehra
pushed a commit
that referenced
this pull request
Feb 14, 2023
Unblocks merging for PR #15952. RELNOTES: PiperOrigin-RevId: 505149043 Change-Id: I1cb5ccb4c162f26fea51e0cdef8c8553f3a3d5df
hvadehra
pushed a commit
that referenced
this pull request
Feb 14, 2023
Adding a few assertions to the worker and multiplex worker tests to ensure that the expected workers are in fact coming up. Closes #15952. PiperOrigin-RevId: 505690186 Change-Id: If732c9f040ec144395b5525a48d3a7d367fe244b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a few assertions to the worker and multiplex worker tests to ensure that the expected workers are in fact coming up.