Replace strdupa with strdup#15763
Closed
graywolf-at-work wants to merge 1 commit intobazelbuild:masterfrom
graywolf-at-work:drop-strdupa
Closed
Replace strdupa with strdup#15763graywolf-at-work wants to merge 1 commit intobazelbuild:masterfrom graywolf-at-work:drop-strdupa
graywolf-at-work wants to merge 1 commit intobazelbuild:masterfrom
graywolf-at-work:drop-strdupa
Conversation
Strdupa has potential to be unsafe thanks to the possibly unbound stack usage. It also generates warnings when compiled on musl. This commit therefore replaces it with properly checked heap allocation using strdup. Fixes #15729
Contributor
Author
|
I've created a PR against master branch, however would it be possible to backport this to 5.x as well? |
Wyverald
approved these changes
Jun 29, 2022
Member
|
To mark a issue as a release blocker (i.e. needs to be backported), simply reply with the comment |
This was referenced Jul 1, 2022
Merged
ckolli5
added a commit
that referenced
this pull request
Jul 2, 2022
Strdupa has potential to be unsafe thanks to the possibly unbound stack usage. It also generates warnings when compiled on musl. This commit therefore replaces it with properly checked heap allocation using strdup. Fixes #15729 Closes #15763. PiperOrigin-RevId: 458440234 Change-Id: I8c8574f654295086f767b4fc4ca6fc1e59097beb Co-authored-by: Tomas Volf <tomas.volf@showmax.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strdupa has potential to be unsafe thanks to the possibly unbound stack
usage. It also generates warnings when compiled on musl. This commit
therefore replaces it with properly checked heap allocation using
strdup.
Fixes #15729