Adds PYTHONSAFEPATH to python_stub_template.txt#15701
Closed
groodt wants to merge 3 commits intobazelbuild:masterfrom
Closed
Adds PYTHONSAFEPATH to python_stub_template.txt#15701groodt wants to merge 3 commits intobazelbuild:masterfrom
groodt wants to merge 3 commits intobazelbuild:masterfrom
Conversation
hrfuller
reviewed
Jul 5, 2022
src/main/java/com/google/devtools/build/lib/bazel/rules/python/python_stub_template.txt
Outdated
Show resolved
Hide resolved
groodt
commented
Jul 5, 2022
src/main/java/com/google/devtools/build/lib/bazel/rules/python/python_stub_template.txt
Outdated
Show resolved
Hide resolved
…/python_stub_template.txt
rickeylev
reviewed
Jul 12, 2022
| if runfiles_envkey: | ||
| new_env[runfiles_envkey] = runfiles_envvalue | ||
|
|
||
| # Don't prepend a potentially unsafe path to sys.path |
Contributor
There was a problem hiding this comment.
fwiw, i'd recommend also linking to the rules_python issue. The unsafe behavior this is trying to prevent isn't immediately obvious.
(apologies for the drive-by comment)
comius
approved these changes
Jul 21, 2022
12 tasks
aignas
added a commit
to aignas/rules_python
that referenced
this pull request
Aug 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: bazel-contrib/rules_python#382