Fix --use_top_level_targets_for_symlinks with aliases#15316
Closed
keith wants to merge 1 commit intobazelbuild:masterfrom
Closed
Fix --use_top_level_targets_for_symlinks with aliases#15316keith wants to merge 1 commit intobazelbuild:masterfrom
keith wants to merge 1 commit intobazelbuild:masterfrom
Conversation
gregestren
reviewed
Apr 25, 2022
Contributor
gregestren
left a comment
There was a problem hiding this comment.
Approach looks good to me: just a few nitty questions.
third_party/googleapis/google/devtools/build/v1/publish_build_event.proto
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/buildtool/ExecutionTool.java
Show resolved
Hide resolved
fc11632 to
aa18b71
Compare
gregestren
approved these changes
Apr 25, 2022
Contributor
|
@bazel-io flag |
|
@bazel-io fork 5.2.0 |
ckolli5
added a commit
that referenced
this pull request
May 10, 2022
meteorcloudy
pushed a commit
that referenced
this pull request
May 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14602