Upgrade Google Auth Version by ThomasCJY · Pull Request #15176 · bazelbuild/bazel

ThomasCJY · 2022-04-04T23:09:21Z

upgrade google auth to use the latest v1.6.0 instead of the outdated 0.17 in bazel

caseyduquettesc · 2022-04-05T00:27:18Z

For some more context, in 1.5.3 built-in retries were added, which improves the reliability of fetching credentials from the metadata server - googleapis/google-auth-library-java@f9a9b8a

bazaglia · 2022-04-06T11:08:37Z

I believe this is also gonna fix #14278

I hope this gets merged soon, the current library is outdated by 3 years and currently prevents me using remote cache with Workload Identity Federation.

coeuvre · 2022-04-06T14:28:14Z

third_party/BUILD

    jars = [
        "api_client/google-api-client-1.22.0.jar",
        "api_client/google-api-client-jackson2-1.22.0.jar",
+        "api_client/google-api-client-gson-1.22.0.jar",


Does that mean the newer version uses gson instead of jackson2? It would be nice if we can remove jackson2.

yes looks like they switched to gson in 0.23.0 https://github.com/googleapis/google-auth-library-java/pull/531/files. Removed jackson dependency in pr

coeuvre · 2022-04-06T14:28:48Z

third_party/BUILD

+        "api_client/google-http-client-gson-1.22.0.jar",
    ],
    runtime_deps = [
        ":jackson2",


We probably need add :gson to runtime_deps on here.

coeuvre

Thanks!

I didn't realize removing jackson2 will introduce non third_party changes. Unfortunately, we can't import PR that include both third_party and non third_party changes. In this case, we have to split the PR into 3 small PRs:

Add Gson and upgrade Auth (third_party only changes)
Replace jackson2 usages in non third_party packages
Remove jackson2

Sorry the import process is not easy enough.

ThomasCJY · 2022-04-11T23:26:28Z

@coeuvre #15215 part 1 PR is here

Follow up for #15215 and Step two for #15176 Closes #15295. PiperOrigin-RevId: 443050332

coeuvre · 2022-04-22T07:42:11Z

This PR has been submitted as 3 sub PRs. Closing.

brentleyjones · 2022-04-29T13:57:09Z

@bazel-io flag

brentleyjones · 2022-04-29T13:57:30Z

@coeuvre I had merge conflicts trying to cherry-pick the 3 sub-PRs. Could you take that on?

Follow up for bazelbuild#15215 and Step two for bazelbuild#15176 Closes bazelbuild#15295. PiperOrigin-RevId: 443050332

ckolli5 · 2022-05-04T14:24:02Z

@bazel-io fork 5.2.0

* [Step 1] Upgrade Google Auth Version third party only changes gson add back jackson Partial commit for third_party/*, see #15215. Closes #15215 Signed-off-by: Yun Peng <pcloudy@google.com> * [Step 2] Update non-third party change for jackson2 Follow up for #15215 and Step two for #15176 Closes #15295. PiperOrigin-RevId: 443050332 * clean up Partial commit for third_party/*, see #15301. Closes: #15301 Signed-off-by: Yun Peng <pcloudy@google.com> Co-authored-by: Thomas Chen <jchen@snapchat.com> Co-authored-by: ThomasCJY <thomascjy93@gmail.com>

In bazelbuild#15176 we upgraded google-auth-library-oauth2-http to 1.6.0, but didn't upgrade its dependencies accordingly; Maven claims 1.41.1 is needed [1]. In turn, a new transitive dependency on opencensus-contrib-http-util 0.31.0 also becomes necessary [2]. [1] https://mvnrepository.com/artifact/com.google.auth/google-auth-library-oauth2-http/1.6.0 [2] https://mvnrepository.com/artifact/com.google.http-client/google-http-client/1.41.1

In bazelbuild#15176 we upgraded google-auth-library-oauth2-http to 1.6.0, but didn't upgrade its dependencies accordingly; Maven claims 1.41.4 is needed [1]. In turn, a new transitive dependency on opencensus-contrib-http-util 0.31.0 also becomes necessary [2]. [1] https://mvnrepository.com/artifact/com.google.auth/google-auth-library-oauth2-http/1.6.0 [2] https://mvnrepository.com/artifact/com.google.http-client/google-http-client/1.41.4

In bazelbuild#15176 we upgraded google-auth-library-oauth2-http to 1.6.0, but didn't upgrade its dependencies accordingly; Maven claims 1.41.4 is needed [1]. In turn, a new transitive dependency on opencensus-contrib-http-util 0.31.0 also becomes necessary [2]. Fixes bazelbuild#15639. [1] https://mvnrepository.com/artifact/com.google.auth/google-auth-library-oauth2-http/1.6.0 [2] https://mvnrepository.com/artifact/com.google.http-client/google-http-client/1.41.4

In #15176 we upgraded google-auth-library-oauth2-http to 1.6.0, but didn't upgrade its dependencies accordingly; Maven claims 1.41.4 is needed [1]. In turn, a new transitive dependency on opencensus-contrib-http-util 0.31.0 also becomes necessary [2]. Fixes #15639. [1] https://mvnrepository.com/artifact/com.google.auth/google-auth-library-oauth2-http/1.6.0 [2] https://mvnrepository.com/artifact/com.google.http-client/google-http-client/1.41.4 Partial commit for third_party/*, see #16082. Signed-off-by: Sunil Gowroji <sgowroji@google.com>

In bazelbuild#15176 we upgraded google-auth-library-oauth2-http to 1.6.0, but didn't upgrade its dependencies accordingly; Maven claims 1.41.4 is needed [1]. In turn, a new transitive dependency on opencensus-contrib-http-util 0.31.0 also becomes necessary [2]. Fixes bazelbuild#15639. [1] https://mvnrepository.com/artifact/com.google.auth/google-auth-library-oauth2-http/1.6.0 [2] https://mvnrepository.com/artifact/com.google.http-client/google-http-client/1.41.4 Partial commit for third_party/*, see bazelbuild#16082. Signed-off-by: Sunil Gowroji <sgowroji@google.com>

In #15176 we upgraded google-auth-library-oauth2-http to 1.6.0, but didn't upgrade its dependencies accordingly; Maven claims 1.41.4 is needed [1]. In turn, a new transitive dependency on opencensus-contrib-http-util 0.31.0 also becomes necessary [2]. Fixes #15639. [1] https://mvnrepository.com/artifact/com.google.auth/google-auth-library-oauth2-http/1.6.0 [2] https://mvnrepository.com/artifact/com.google.http-client/google-http-client/1.41.4 Partial commit for third_party/*, see #16082. Signed-off-by: Sunil Gowroji <sgowroji@google.com> Signed-off-by: Sunil Gowroji <sgowroji@google.com>

update

c42b1df

add gson dep

3e4d7d5

sgowroji added the team-Remote-Exec Issues and PRs for the Execution (Remote) team label Apr 6, 2022

coeuvre reviewed Apr 6, 2022

View reviewed changes

remove jackson

001892e

ThomasCJY requested a review from a team as a code owner April 6, 2022 19:20

ThomasCJY requested review from coeuvre and removed request for a team April 6, 2022 19:21

coeuvre reviewed Apr 7, 2022

View reviewed changes

This was referenced Apr 12, 2022

[Step 1] Upgrade Google Auth Version #15215

Closed

[Step 2] Update non-third party change for jackson2 #15295

Closed

bazel-io pushed a commit that referenced this pull request Apr 20, 2022

[Step 2] Update non-third party change for jackson2

d8feb4d

Follow up for #15215 and Step two for #15176 Closes #15295. PiperOrigin-RevId: 443050332

ThomasCJY mentioned this pull request Apr 20, 2022

[Step 3] clean up #15301

Closed

sgowroji added the awaiting-review PR is awaiting review from an assigned reviewer label Apr 21, 2022

coeuvre closed this Apr 22, 2022

coeuvre mentioned this pull request Apr 28, 2022

Bazel Remote Cache: Cannot use WIF-generated credentials #14278

Closed

bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Apr 29, 2022

coeuvre pushed a commit to coeuvre/bazel that referenced this pull request May 2, 2022

[Step 2] Update non-third party change for jackson2

a965c5a

Follow up for bazelbuild#15215 and Step two for bazelbuild#15176 Closes bazelbuild#15295. PiperOrigin-RevId: 443050332

coeuvre mentioned this pull request May 2, 2022

[5.2] Upgrade Google Auth Version #15383

Merged

bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label May 4, 2022

bazel-io mentioned this pull request May 4, 2022

[5.2.0] Upgrade Google Auth Version #15399

Closed

This was referenced Aug 10, 2022

Upgrade google-http-client and google-http-client-gson. #16082

Closed

Bazel 5.2 Google Cloud's Workload identity federation auth seems broken #15639

Closed

ShreeM01 removed the awaiting-review PR is awaiting review from an assigned reviewer label Sep 15, 2022

mauriciogg mentioned this pull request Sep 29, 2022

[fix] Update google-api-client to 1.35.0 #16358

Closed

tjgq mentioned this pull request Nov 11, 2022

[5.4.0] Upgrade google-http-client and google-http-client-gson. #16745

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade Google Auth Version#15176

Upgrade Google Auth Version#15176
ThomasCJY wants to merge 3 commits intobazelbuild:masterfrom
ThomasCJY:jchen-updateAuthVersion

ThomasCJY commented Apr 4, 2022

Uh oh!

caseyduquettesc commented Apr 5, 2022

Uh oh!

bazaglia commented Apr 6, 2022

Uh oh!

coeuvre Apr 6, 2022

Uh oh!

ThomasCJY Apr 6, 2022

Uh oh!

coeuvre Apr 6, 2022

Uh oh!

ThomasCJY Apr 6, 2022

Uh oh!

coeuvre left a comment

Uh oh!

ThomasCJY commented Apr 11, 2022

Uh oh!

coeuvre commented Apr 22, 2022

Uh oh!

brentleyjones commented Apr 29, 2022

Uh oh!

brentleyjones commented Apr 29, 2022

Uh oh!

ckolli5 commented May 4, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Conversation

ThomasCJY commented Apr 4, 2022

Uh oh!

caseyduquettesc commented Apr 5, 2022

Uh oh!

bazaglia commented Apr 6, 2022

Uh oh!

coeuvre Apr 6, 2022

Choose a reason for hiding this comment

Uh oh!

ThomasCJY Apr 6, 2022

Choose a reason for hiding this comment

Uh oh!

coeuvre Apr 6, 2022

Choose a reason for hiding this comment

Uh oh!

ThomasCJY Apr 6, 2022

Choose a reason for hiding this comment

Uh oh!

coeuvre left a comment

Choose a reason for hiding this comment

Uh oh!

ThomasCJY commented Apr 11, 2022

Uh oh!

coeuvre commented Apr 22, 2022

Uh oh!

brentleyjones commented Apr 29, 2022

Uh oh!

brentleyjones commented Apr 29, 2022

Uh oh!

ckolli5 commented May 4, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants