config doesn't error on duplicate --define values#14760
Closed
illicitonion wants to merge 1 commit intobazelbuild:masterfrom
Closed
config doesn't error on duplicate --define values#14760illicitonion wants to merge 1 commit intobazelbuild:masterfrom
--define values#14760illicitonion wants to merge 1 commit intobazelbuild:masterfrom
Conversation
When `--define` flags are interpreted by other commands, the last one wins. Currently `bazel config` causes a server crash when interpreting duplicate `--define` values. This change makes `config` consistent with the other commands, and re-uses the same deduplication code across all call-sites.
katre
approved these changes
Feb 8, 2022
Collaborator
katre
left a comment
There was a problem hiding this comment.
Looks good, I'll get this merged once the tests pass.
illicitonion
added a commit
to illicitonion/bazel
that referenced
this pull request
Feb 8, 2022
When `--define` flags are interpreted by other commands, the last one wins. Currently `bazel config` causes a server crash when interpreting duplicate `--define` values. This change makes `config` consistent with the other commands, and re-uses the same deduplication code across all call-sites. Closes bazelbuild#14760. PiperOrigin-RevId: 427266039
Contributor
Author
|
@bazel-io fork 5.2 |
1 similar comment
Member
|
@bazel-io fork 5.2 |
Contributor
Author
|
@bazel-io flag |
|
@bazel-io fork 5.2.0 |
ckolli5
added a commit
that referenced
this pull request
May 12, 2022
When `--define` flags are interpreted by other commands, the last one wins. Currently `bazel config` causes a server crash when interpreting duplicate `--define` values. This change makes `config` consistent with the other commands, and re-uses the same deduplication code across all call-sites. Closes #14760. PiperOrigin-RevId: 427266039 Co-authored-by: Daniel Wagner-Hall <dwagnerhall@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
--defineflags are interpreted by other commands, the last onewins. Currently
bazel configcauses a server crash when interpretingduplicate
--definevalues.This change makes
configconsistent with the other commands, andre-uses the same deduplication code across all call-sites.