Fix ctx.fragments.apple.single_arch_cpu returning incorrect cpu for tools when host cpu and exec cpu are different#14665
Closed
thii wants to merge 1 commit intobazelbuild:masterfrom
Conversation
76f373a to
9bf3d7d
Compare
tools when host cpu and exec cpu are different
9bf3d7d to
b399a17
Compare
Contributor
|
@keith @brentleyjones are you comfortable reviewing PRs like this (especially given pending OWNERS updates)? Or do you recommend elsewhere? |
keith
approved these changes
Feb 1, 2022
Member
|
Yes, also in this case @katre since you investigated this issue as well maybe you have some thoughts? |
katre
approved these changes
Feb 2, 2022
Collaborator
katre
left a comment
There was a problem hiding this comment.
Looks good, I'll import this and get it in front of the internal experts today.
brentleyjones
pushed a commit
to brentleyjones/bazel
that referenced
this pull request
Feb 8, 2022
… tools when host cpu and exec cpu are different Fixes bazelbuild#14291 Closes bazelbuild#14665. PiperOrigin-RevId: 425886938 (cherry picked from commit fce7ea8)
Wyverald
pushed a commit
that referenced
this pull request
Feb 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14291