[apple] support watchos_arm64 in toolchain#14512
[apple] support watchos_arm64 in toolchain#14512dflems wants to merge 1 commit intobazelbuild:masterfrom
Conversation
| "watchos_arm64": [ | ||
| "@platforms//os:ios", | ||
| "@platforms//cpu:aarch64", | ||
| ], |
There was a problem hiding this comment.
not sure if this will conflict with the one below or if there's a different CPU that should be used for one or the other?
There was a problem hiding this comment.
It looks like it may in the future. If the constraints are the same, toolchain resolution would pick this one first.
But, what is up with the name watchos_arm64_32?
That entry is strange with a name that implies 32 bits, while using aarch64.
There was a problem hiding this comment.
arm64_32 is a variant of arm64 with 32-bit pointer sizes, used on Apple Watch Series 4 and later.
There was a problem hiding this comment.
I wasn't sure about these. But ios_sim_arm64 and ios_arm64 are identical here too, so if it's wrong what's in here already is wrong.
|
cc @Wyverald @kaylathar I broke this out of that other PR (#14439). The |
|
This LGTM - no concerns |
|
@oquenchil or @Wyverald can you import? |
aiuto
left a comment
There was a problem hiding this comment.
Not really a review. I don't have enough knowledge of the Apple naming conventions.
| "watchos_arm64": [ | ||
| "@platforms//os:ios", | ||
| "@platforms//cpu:aarch64", | ||
| ], |
There was a problem hiding this comment.
It looks like it may in the future. If the constraints are the same, toolchain resolution would pick this one first.
But, what is up with the name watchos_arm64_32?
That entry is strange with a name that implies 32 bits, while using aarch64.
|
I'll do the import. |
|
@katre asks:
|
|
I don't think this change should change those, as that's a much larger and riskier change for this current addition. |
|
Someone should investigate these, but I don't know enough about the difference between the ios variants to know what's correct. |
The watch-only changes from bazelbuild#14439 Closes bazelbuild#14512. PiperOrigin-RevId: 420296580 (cherry picked from commit b341802)
The watch-only changes from #14439