Skip to content

Add zstd-jni to //third_party.#12437

Closed
philwo wants to merge 1 commit intomasterfrom
philwo-thirdparty-11968
Closed

Add zstd-jni to //third_party.#12437
philwo wants to merge 1 commit intomasterfrom
philwo-thirdparty-11968

Conversation

@philwo
Copy link
Copy Markdown
Member

@philwo philwo commented Nov 9, 2020

Extracted from #11968, as I have to merge this separately from the rest
of that PR.

@philwo philwo self-assigned this Nov 9, 2020
@google-cla google-cla bot added the cla: yes label Nov 9, 2020
@philwo
Copy link
Copy Markdown
Member Author

philwo commented Nov 9, 2020

Will merge when presubmits pass.

@philwo
Add zstd-jni to //third_party.
fb465cb 
Extracted from #11968, as I have to merge this separately from the rest
of that PR.
@philwo philwo force-pushed the philwo-thirdparty-11968 branch from 354f09e to fb465cb Compare November 9, 2020 17:22
bazel-io pushed a commit that referenced this pull request Nov 9, 2020
@philwo
Add zstd-jni to //third_party.
941fe0a 
Extracted from #11968, as I have to merge this separately from the rest
of that PR.

Partial commit for third_party/*, see #12437.

Signed-off-by: Philipp Wollermann <philwo@google.com>
@philwo
Copy link
Copy Markdown
Member Author

philwo commented Nov 9, 2020

Merged in 941fe0a

@philwo philwo closed this Nov 9, 2020
@philwo philwo deleted the philwo-thirdparty-11968 branch November 9, 2020 21:24
@keith
Copy link
Copy Markdown
Member

keith commented Nov 10, 2020

FYI when building on macOS this results in dozens of warnings:

warning: unknown warning option '-Wno-maybe-uninitialized'; did you mean '-Wno-uninitialized'? [-Wunknown-warning-option]
1 warning generated.
INFO: From Compiling com_github_luben_zstd_jni/src/main/native/compress/zstd_compress_literals.c:
warning: unknown warning option '-Wno-maybe-uninitialized'; did you mean '-Wno-uninitialized'? [-Wunknown-warning-option]
1 warning generated.
INFO: From Compiling com_github_luben_zstd_jni/src/main/native/compress/zstd_compress.c:
warning: unknown warning option '-Wno-maybe-uninitialized'; did you mean '-Wno-uninitialized'? [-Wunknown-warning-option]
1 warning generated.
INFO: From Compiling com_github_luben_zstd_jni/src/main/native/compress/zstd_fast.c:
warning: unknown warning option '-Wno-maybe-uninitialized'; did you mean '-Wno-uninitialized'? [-Wunknown-warning-option]
1 warning generated.
INFO: From Compiling com_github_luben_zstd_jni/src/main/native/compress/zstd_double_fast.c:
warning: unknown warning option '-Wno-maybe-uninitialized'; did you mean '-Wno-uninitialized'? [-Wunknown-warning-option]
1 warning generated.
INFO: From Compiling com_github_luben_zstd_jni/src/main/native/compress/zstd_compress_sequences.c:
warning: unknown warning option '-Wno-maybe-uninitialized'; did you mean '-Wno-uninitialized'? [-Wunknown-warning-option]
1 warning generated.
INFO: From Compiling com_github_luben_zstd_jni/src/main/native/compress/huf_compress.c:
warning: unknown warning option '-Wno-maybe-uninitialized'; did you mean '-Wno-uninitialized'? [-Wunknown-warning-option]
1 warning generated.
INFO: From Compiling com_github_luben_zstd_jni/src/main/native/jni_zdict.c:
warning: unknown warning option '-Wno-maybe-uninitialized'; did you mean '-Wno-uninitialized'? [-Wunknown-warning-option]
external/com_github_luben_zstd_jni/src/main/native/jni_zdict.c:28:9: warning: variable 'size' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
    if (!samples_buffer) {
        ^~~~~~~~~~~~~~~
external/com_github_luben_zstd_jni/src/main/native/jni_zdict.c:55:12: note: uninitialized use occurs here
E1: return size;
           ^~~~
external/com_github_luben_zstd_jni/src/main/native/jni_zdict.c:28:5: note: remove the 'if' if its condition is always false
    if (!samples_buffer) {
    ^~~~~~~~~~~~~~~~~~~~~~
external/com_github_luben_zstd_jni/src/main/native/jni_zdict.c:14:9: warning: variable 'size' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
    if (!samples_sizes) {
        ^~~~~~~~~~~~~~
external/com_github_luben_zstd_jni/src/main/native/jni_zdict.c:55:12: note: uninitialized use occurs here
E1: return size;
           ^~~~
external/com_github_luben_zstd_jni/src/main/native/jni_zdict.c:14:5: note: remove the 'if' if its condition is always false
    if (!samples_sizes) {
    ^~~~~~~~~~~~~~~~~~~~~
external/com_github_luben_zstd_jni/src/main/native/jni_zdict.c:44:16: note: initialize the variable 'size' to silence this warning
    size_t size;
               ^
                = 0
external/com_github_luben_zstd_jni/src/main/native/jni_zdict.c:74:9: warning: variable 'size' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
    if (sample_sizes_array == NULL) goto E2;
        ^~~~~~~~~~~~~~~~~~~~~~~~~~
external/com_github_luben_zstd_jni/src/main/native/jni_zdict.c:89:12: note: uninitialized use occurs here
E1: return size;
           ^~~~
external/com_github_luben_zstd_jni/src/main/native/jni_zdict.c:74:5: note: remove the 'if' if its condition is always false
    if (sample_sizes_array == NULL) goto E2;
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
external/com_github_luben_zstd_jni/src/main/native/jni_zdict.c:68:9: warning: variable 'size' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
    if (!samples_sizes) {
        ^~~~~~~~~~~~~~
external/com_github_luben_zstd_jni/src/main/native/jni_zdict.c:89:12: note: uninitialized use occurs here
E1: return size;
           ^~~~
external/com_github_luben_zstd_jni/src/main/native/jni_zdict.c:68:5: note: remove the 'if' if its condition is always false
    if (!samples_sizes) {
    ^~~~~~~~~~~~~~~~~~~~~
external/com_github_luben_zstd_jni/src/main/native/jni_zdict.c:80:16: note: initialize the variable 'size' to silence this warning
    size_t size;
               ^
                = 0
5 warnings generated.
INFO: From Compiling com_github_luben_zstd_jni/src/main/native/jni_outputstream_zstd.c:
warning: unknown warning option '-Wno-maybe-uninitialized'; did you mean '-Wno-uninitialized'? [-Wunknown-warning-option]
1 warning generated.
INFO: From Compiling com_github_luben_zstd_jni/src/main/native/jni_directbufferdecompress_zstd.c:
warning: unknown warning option '-Wno-maybe-uninitialized'; did you mean '-Wno-uninitialized'? [-Wunknown-warning-option]
1 warning generated.
INFO: From Compiling com_github_luben_zstd_jni/src/main/native/dictBuilder/divsufsort.c:
warning: unknown warning option '-Wno-maybe-uninitialized'; did you mean '-Wno-uninitialized'? [-Wunknown-warning-option]
1 warning generated.
INFO: From Compiling com_github_luben_zstd_jni/src/main/native/legacy/zstd_v06.c:
warning: unknown warning option '-Wno-maybe-uninitialized'; did you mean '-Wno-uninitialized'? [-Wunknown-warning-option]
1 warning generated.
INFO: From Compiling com_github_luben_zstd_jni/src/main/native/compress/zstdmt_compress.c:
warning: unknown warning option '-Wno-maybe-uninitialized'; did you mean '-Wno-uninitialized'? [-Wunknown-warning-option]
1 warning generated.
INFO: From Compiling com_github_luben_zstd_jni/src/main/native/jni_directbuffercompress_zstd.c:
warning: unknown warning option '-Wno-maybe-uninitialized'; did you mean '-Wno-uninitialized'? [-Wunknown-warning-option]
1 warning generated.
INFO: From Compiling com_github_luben_zstd_jni/src/main/native/jni_inputstream_zstd.c:
warning: unknown warning option '-Wno-maybe-uninitialized'; did you mean '-Wno-uninitialized'? [-Wunknown-warning-option]
1 warning generated.
INFO: From Compiling com_github_luben_zstd_jni/src/main/native/jni_fast_zstd.c:
warning: unknown warning option '-Wno-maybe-uninitialized'; did you mean '-Wno-uninitialized'? [-Wunknown-warning-option]
1 warning generated.

@keith
Copy link
Copy Markdown
Member

keith commented Nov 10, 2020

Fix here #12443

@benjaminp benjaminp mentioned this pull request Sep 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@philwo philwo

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@philwo @keith