Update the Readme to give a short description of bazel.#1
Closed
Update the Readme to give a short description of bazel.#1
Conversation
README.md
Outdated
Contributor
There was a problem hiding this comment.
Not eloquent enough. Try harder.
Contributor
Author
|
How about this? |
Conflicts: README.md
Closed
bazel-io
pushed a commit
that referenced
this pull request
May 4, 2016
Add dagger to third_party in preparation for an upcoming conversion of the junit test runner from Guice to Dagger. Part #1: without the BUILD file (needs a separate change) Change-Id: Idae2182c491e01d2f0b5e852a5314e65624592c6
Closed
copybara-service bot
pushed a commit
that referenced
this pull request
Mar 14, 2023
*** Reason for rollback *** Breaks builds internally. *** Original change description *** Move Apple toolchain setup to apple_support This moves the CC toolchain for building Apple platforms besides macOS to the apple_support repo bazelbuild/apple_support#113 The default unix toolchain is now used if someone wants to build for macOS without the apple_support toolchain, but it doesn't handle as many platform specific features as the previous toolchain. Fixes #1... *** PiperOrigin-RevId: 516486823 Change-Id: If9b2542699cf8704e0a511e684d8519468ddd937
fweikert
pushed a commit
to fweikert/bazel
that referenced
this pull request
May 25, 2023
*** Reason for rollback *** Breaks builds internally. *** Original change description *** Move Apple toolchain setup to apple_support This moves the CC toolchain for building Apple platforms besides macOS to the apple_support repo bazelbuild/apple_support#113 The default unix toolchain is now used if someone wants to build for macOS without the apple_support toolchain, but it doesn't handle as many platform specific features as the previous toolchain. Fixes bazelbuild#1... *** PiperOrigin-RevId: 516486823 Change-Id: If9b2542699cf8704e0a511e684d8519468ddd937
copybara-service bot
pushed a commit
that referenced
this pull request
Oct 10, 2023
… order.
1. `TestAttempt` events would wait for the `TargetCompleteEvent` to be posted before being posted.
2. There was an implicit requirement for the `TestAttempt` events to be posted in a specific order.
3. This didn't break in the noskymeld case because we fulfilled this ordering by using the order of performing the attempts themselves. The sequence would look like:
+ post `TargetCompleteEvent`
-> perform attempt #1
-> post `TestAttempt` #1
-> perform attempt #2
-> post `TestAttempt` #2
4. With skymeld, however, it could happen like this:
+ defer `TargetCompleteEvent` to wait for `CoverageActionFinishedEvent`
+ perform attempt #1 -> defer posting `TestAttempt` #1 & wait for `TargetCompleteEvent`
+ perform attempt #2 -> defer posting `TestAttempt` #2 & wait for `TargetCompleteEvent`
+ `CoverageActionFinishedEvent` -> release & post `TargetCompleteEvent`
+ `TargetCompleteEvent` -> release & post `TestAttempt` #2
+ `TargetCompleteEvent` -> release & post `TestAttempt` #1
Due to (2), the undefined ordering in (4) would cause an issue.
This CL fixes that by ensuring a FIFO ordering of the deferred events.
PiperOrigin-RevId: 572165337
Change-Id: Iac4d023d946865b8b81f15b119417192dc4b5c53
This was referenced Jul 21, 2024
2 tasks
copybara-service bot
pushed a commit
that referenced
this pull request
Mar 16, 2026
Previously, child events could be published before their parent events during a race in the `BuildEventStreamer#post` method. This method was not synchronized around delivering events to the `BuildEventTransport` objects, so it was possible for this race to occur: Thread #1 | Thread #2 ----------|----------- make parent event | post parent event | | make child event | post child event | deliver child event deliver parent event | TESTED: extensive benchmarking rules out increase in wall time or heap high-water-mark. RELNOTES: BEP events will now be written respecting parent-child ordering constraints. PiperOrigin-RevId: 884592559 Change-Id: Iaaac7f48b849c146632fbc10ce3c2e4e1fa6af07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.