-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Revisit --enable_runfiles #9248
Copy link
Copy link
Closed
Labels
P3We're not considering working on this, but happy to review a PR. (No assignee)We're not considering working on this, but happy to review a PR. (No assignee)team-Remote-ExecIssues and PRs for the Execution (Remote) teamIssues and PRs for the Execution (Remote) teamtype: feature request
Description
The flags --build_runfile_manifests and --build_runfile_links govern whether runfile manifests and runfile trees should be created at the time of building a binary. bazel run/test has extra logic to create runfile trees on-demand if --nobuild_runfile_links is set. This is where --enable_runfiles comes in. It disables any runfile trees creation and instead only copies the input manifest to the output manifest.
- I suggest we deprecate and remove the flag.
- Instead we introduce
--test_runfile_linkswhich enables/disables the symlink tree creation forbazel run/test. On Windows, both--build_runfile_linksand--test_runfile_linkswould be disabled by default. - In case of
--nobuild_runfile_linksit also copies the input manifest to the output manifest. This is unnecessary and can be slow. - It has a correctness issue in that if its value changes analysis is not rerun: Runfiles tree is not recreated when value of
--enable_runfileschanges #9150
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
P3We're not considering working on this, but happy to review a PR. (No assignee)We're not considering working on this, but happy to review a PR. (No assignee)team-Remote-ExecIssues and PRs for the Execution (Remote) teamIssues and PRs for the Execution (Remote) teamtype: feature request